search

puppetlabs / puppetlabs-node_manager

Create and manage PE node groups as resources.
Apache License 2.0
10 stars 22 forks source link

Error in the example in the README.md #57

Closed 16c7x closed 4 years ago

16c7x commented 4 years ago

The readme includes the example;

node_group { 'PE MCollective':
  ensure               => 'present',
  classes              => {'puppet_enterprise::profile::mcollective::agent' => {}},
  environment          => 'production',
  id                   => '4cdec347-20c6-46d7-9658-7189c1537ae9',
  override_environment => 'false',
  parent               => 'PE Infrastructure',
  rule                 => ['and', ['~', ['fact', 'pe_version'], '.+']],
}

The line override_environment => 'false', should read override_environment => false,. The quotes mean Puppet interprets it as a string rather than a boolean, it cases an error when it runs, it's confusing for new users.

16c7x commented 4 years ago

Closed and raised a PR with the fix.