search

puppetlabs / puppetlabs-node_manager

Create and manage PE node groups as resources.
Apache License 2.0
10 stars 21 forks source link

Puppet 8 / Ruby 3 compatibility #71

Closed MartyEwings closed 1 year ago

MartyEwings commented 1 year ago

Prior to this commit this module consumed Ruby Functions deprecated in ruby 2.x, as the deprecations where removed in Ruby 3.x these functions where replaced with their compatible ruby 2/3 alternates.

This commits adds Support for Puppet 8, and I confirm that compatibility with Puppet 6 and 7 is still present, I have not tested anything prior to that.

The functions exists? which is the main focus of these changes, was deprecated in ruby 2.2 and had the alternate exist? present since this time, so its safe to assume puppet 4 and 5 would maintain compatibility.

However since this module target is PE and Even Puppet 6 versions of PE have reached EOL i have not been able to test further back.

This Commit also includes non impactful styling changes so as to pass the linting requirements for PDK

MartyEwings commented 1 year ago

@WhatsARanjit updated compatibility in description