puppetlabs / puppetlabs-node_manager

Create and manage PE node groups as resources.
Apache License 2.0
10 stars 21 forks source link

When purge_behavior => 'none' a corrective change is generated every puppet agent run #72

Open miharp opened 10 months ago

miharp commented 10 months ago

Steps to Reproduce

node_group { 'PE Master':
      parent         => 'PE Infrastructure',
      purge_behavior => 'none',
      data           =>
        {
          'puppet_enterprise::master::code_manager' =>
          {
            'deploy_pool_size' => $deploy_pool_size,
            'timeouts_deploy'  => 900,
            'timeouts_fetch'   => 600,
            'timeouts_sync'    => 1200,
          },
          'puppet_enterprise::master::file_sync'    =>
          {
            'file_sync_stream_file_threshold' => $stream_file_threshold,
          },
        }
    }
/root]# puppet agent -t
Info: Using environment 'ifb400'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Notice: /Stage[main]/Puppet::Enterprise_server/Node_group[PE Master]/data: data changed {
  'pe_repo' => {
    'compile_master_pool_address' => 'pe-puppet'
  },
  'puppet_enterprise::master::code_manager' => {
    'deploy_pool_size' => 4,
    'timeouts_deploy' => 900,
    'timeouts_fetch' => 600,
    'timeouts_sync' => 1200
  },
  'puppet_enterprise::master::file_sync' => {
    'file_sync_stream_file_threshold' => 2048
  }
} to {
  'pe_repo' => {
    'compile_master_pool_address' => 'pe-puppet'
  },
  'puppet_enterprise::master::code_manager' => {
    'deploy_pool_size' => 4,
    'timeouts_deploy' => 900,
    'timeouts_fetch' => 600,
    'timeouts_sync' => 1200
  },
  'puppet_enterprise::master::file_sync' => {
    'file_sync_stream_file_threshold' => 2048
  }
}
Notice: Applied catalog in 79.36 seconds

[/root]# rpm -q pe-puppet-enterprise-release
pe-puppet-enterprise-release-2021.7.4.0-4.pe.el7.noarch
miharp commented 10 months ago

Note: To reproduce the Node Group must contain configuration data not managed by the module, in our case it is data created by peadm during cluster provisioning, pe_repo::compile_master_pool_address='pe-puppet'