search

puppetlabs / puppetlabs-package

A Puppet Task module, for package.
Apache License 2.0
9 stars 25 forks source link

Fix shebangs #305

Closed smortex closed 1 year ago

smortex commented 1 year ago

bash(1) is not always installed in /bin, we can only assume /bin/sh is a bourne shell, and for any other non-portable shell rely on env(1) (always available as /usr/bin/env) to find the appropriate command in $PATH.

While here, remove shebangs from non-executable files.

smortex commented 1 year ago

Relying on a portable shell with bare /bin/sh would also be an enhancement for systems where bash is not needed and allow to add supports for more systems, but this require much more work so is left for later.

jordanbreen28 commented 1 year ago

@smortex I've went ahead and kicked off a rebase, will merge when green!