Closed taikaa closed 1 year ago
@taikaa could u rebase on main
@MartyEwings hi! I squashed my commits and rebased on main. The tests are failing on S0019
@taikaa hate to do this, but i merged a couple of things including something that should stop fails on s0019, could you rebase again on main/
I was looking over this one and I do appreciate the PR, but I think that we probably want to avoid parsing the entire last run report. On my primary the file is almost 3mb, and I'm sure customers with lots of resources or agent runs that produce large corrective changes will have larger. The overhead of parsing the file into yaml and iterating over the lines every agent and facter
run could be significant.
Closing due to the time and memory impact adding this check to the fact would cause
Thanks for the PR
Added in agent_status_check indicator AS005 to review the lastrunreport for any logs at Warning or Error level. The indicator resolves to false if there is at least one Warning or Error. This indicator is helpful to capture errors that might not cause the Puppet run to fail such as Facter errors.
Please check off the steps below as you complete each step
(SUP-XXXX) Add Super Duper State Check
Ready for Review
if there is one