puppetlabs / puppetlabs-pe_status_check

Self Service Module for Puppet Enterprise
Apache License 2.0
1 stars 33 forks source link

(SUP-4204) Add lastrunreport check #189

Closed taikaa closed 1 year ago

taikaa commented 1 year ago

Added in agent_status_check indicator AS005 to review the lastrunreport for any logs at Warning or Error level. The indicator resolves to false if there is at least one Warning or Error. This indicator is helpful to capture errors that might not cause the Puppet run to fail such as Facter errors.

Please check off the steps below as you complete each step

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

MartyEwings commented 1 year ago

@taikaa could u rebase on main

taikaa commented 1 year ago

@MartyEwings hi! I squashed my commits and rebased on main. The tests are failing on S0019

MartyEwings commented 1 year ago

@taikaa hate to do this, but i merged a couple of things including something that should stop fails on s0019, could you rebase again on main/

m0dular commented 1 year ago

I was looking over this one and I do appreciate the PR, but I think that we probably want to avoid parsing the entire last run report. On my primary the file is almost 3mb, and I'm sure customers with lots of resources or agent runs that produce large corrective changes will have larger. The overhead of parsing the file into yaml and iterating over the lines every agent and facter run could be significant.

MartyEwings commented 1 year ago

Closing due to the time and memory impact adding this check to the fact would cause

Thanks for the PR