(SUP-4282) add error handling to S0044 - Githubissues

puppetlabs / puppetlabs-pe_status_check

Self Service Module for Puppet Enterprise

Apache License 2.0

1 stars 33 forks source link

(SUP-4282) add error handling to S0044 #192

Closed taikaa closed 1 year ago

taikaa commented 1 year ago

This commit adds error handling to S0044 to guard against Facter failures such as a NoMethodError for the set_in_section method.

Please check off the steps below as you complete each step

[x] Put the Jira ticket or Github issue number in parentheses in the Title e.g. (SUP-XXXX) Add Super Duper State Check
[x] Update the Jira ticket status to Ready for Review if there is one
[x] Review any CI failures and fix issues

taikaa commented 1 year ago

PR has been created with broad error handling. Perhaps this should be more specific with different exception classes such as NoMethodError etc. Let me know your thoughts!