search

puppetlabs / puppetlabs-pe_status_check

Self Service Module for Puppet Enterprise
Apache License 2.0
1 stars 33 forks source link

Refactor hiera data into a hash #198

Closed timidri closed 1 year ago

timidri commented 1 year ago

This PR refactors hiera data into a hash and modifies lookups in manifests and plans accordingly.

We now make use of this hiera lookup feature: https://www.puppet.com/docs/puppet/8/hiera_automatic.html#access_hash_array-elements_keysubkey_notation

m0dular commented 1 year ago

Hi @timidri, sorry for the delay but I looked into this and raised another PR, #199. The main difference is that the plans and main class only look up the hash of checks once, instead of a lookup for every key within the hash. Let me know if you want to review/merge that PR, apply its changes here, or something else.

timidri commented 1 year ago

Hi @timidri, sorry for the delay but I looked into this and raised another PR, #199. The main difference is that the plans and main class only look up the hash of checks once, instead of a lookup for every key within the hash. Let me know if you want to review/merge that PR, apply its changes here, or something else.

Sorry for the delay. I'll close this PR in favor of #199 .