(PE-37235) Verify and update documentation on add_compiler

puppetlabs / puppetlabs-peadm

A Puppet module defining Bolt plans used to automate Puppet Enterprise deployments

Apache License 2.0

29 stars 53 forks source link

(PE-37235) Verify and update documentation on add_compiler #429

Closed cathal41 closed 2 weeks ago

cathal41 commented 4 months ago

Adding new documentation page for the new add compiler plan

Additional Context

N/A

Related Issues (if any)

N/A

Checklist

[ ] 🟢 Spec tests.
[ ] 🟢 Acceptance tests.

Changes include test coverage?

[ ] Yes
[ ] Not needed

Have you updated the documentation?

[ ] Yes, I've updated the appropriate docs
[ ] Not needed

ragingra commented 1 month ago

General comment: I was under the impression that peadm::add_compiler was supposed to support both compilers with and without puppetdb, so peadm::add_compiler can be used by customers who have compilers without puppetdb on them.

@timidri This will be included as part of the legacy compiler work which is still work-in-progress

CoMfUcIoS commented 1 month ago

Hey @timidri and @J-Hunniford, can we have another look on this PR please? Any other concerns, comments?