search

puppetlabs / puppetlabs-peadm

A Puppet module defining Bolt plans used to automate Puppet Enterprise deployments
Apache License 2.0
29 stars 53 forks source link

PE-38219 - Support air gapped installation while using a Windows as Jump host #438

Closed cathal41 closed 2 months ago

cathal41 commented 4 months ago

Summary

Adding powershell script files for Filesize, Download and the new os Identifier to allow windows users to preform an air gapped installation

Installer download progress support https://github.com/puppetlabs/installer/pull/481

Checklist

Changes include test coverage?

Have you updated the documentation?

bastelfreak commented 2 months ago

@cathal41 there were still open comments. Why was the PR merged? (the same happened in https://github.com/puppetlabs/puppetlabs-peadm/pull/339)

cathal41 commented 2 months ago

@cathal41 there were still open comments. Why was the PR merged? (the same happened in #339)

This test failure is beyond our control. A PR has been raised to reinstate this test once the fix is available. https://github.com/puppetlabs/puppetlabs-peadm/pull/452

bastelfreak commented 2 months ago

I don't mind temporary test failures, but https://github.com/puppetlabs/puppetlabs-peadm/pull/438/files#r1639580463 is still an open discussion