(PE-38155) Updating node_manager to use Latest Puppetlabs version

[ragingra]

Summary

Updating node_manager to use latest Puppetlabs version

Adding rule purge to PE Infrastructure Agent

• Allowing PEADM to reassert required group rules with new node_manager version

Docs to be updated and add warning around PEADM controlling PE Infrastructure Agent

Additional Context

Add any additional context about the problem here.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

• [x] 🟢 Spec tests.
• [x] 🟢 Acceptance tests.

Changes include test coverage?

• [x] Yes
• [ ] Not needed

Have you updated the documentation?

• [ ] Yes, I've updated the appropriate docs
• [x] Not needed

[bastelfreak]

@ragingra @Jo-Lillie can you please explain why PRs are being merged when there are still open discussions?

• https://github.com/puppetlabs/puppetlabs-peadm/pull/451#pullrequestreview-2171327830
• https://github.com/puppetlabs/puppetlabs-peadm/pull/438
• https://github.com/puppetlabs/puppetlabs-peadm/pull/339

[ragingra]

@bastelfreak

• https://github.com/puppetlabs/puppetlabs-peadm/pull/451 All comments had been addressed.

• https://github.com/puppetlabs/puppetlabs-peadm/pull/438 @cathal41 Looked into your suggestion and felt his implementation was simpler.

• https://github.com/puppetlabs/puppetlabs-peadm/pull/339 PR marked for review for two weeks before being merged. Comments left after it was closed. I'll review and raise tech debt tickets where required.

[bastelfreak]

• https://github.com/puppetlabs/puppetlabs-peadm/pull/451 has an open discussion in the Puppetfile
• https://github.com/puppetlabs/puppetlabs-peadm/pull/438/files#diff-36f82e371453dc661d9875b707cf11c5a7ef477bbbcb93c37810b89c867b3f57 the discussion was also open.
• https://github.com/puppetlabs/puppetlabs-peadm/pull/339/files#r1400527387 my comment there was from 2023 . Yes the other comments happened after the merge. I didn't had the impression that it will be merged soon because of the inconsistent quoting.

[ragingra]

@bastelfreak

https://github.com/puppetlabs/puppetlabs-peadm/pull/451 I beleive I replied sufficiently for the scope of the PR. If you feel more discussion is required for the Puppetfile, please open an issue.

https://github.com/puppetlabs/puppetlabs-peadm/pull/339/files#r1400527387 This was also responded to at the time, and I feel not something that should hold up a ticket, but be rectified in subsequent PR.

I'll try and make sure relevant discussions are properly wrapped up as we go forward