Closed ragingra closed 1 month ago
@ragingra @Jo-Lillie can you please explain why PRs are being merged when there are still open discussions?
@bastelfreak
https://github.com/puppetlabs/puppetlabs-peadm/pull/451 All comments had been addressed.
https://github.com/puppetlabs/puppetlabs-peadm/pull/438 @cathal41 Looked into your suggestion and felt his implementation was simpler.
https://github.com/puppetlabs/puppetlabs-peadm/pull/339 PR marked for review for two weeks before being merged. Comments left after it was closed. I'll review and raise tech debt tickets where required.
@bastelfreak
https://github.com/puppetlabs/puppetlabs-peadm/pull/451 I beleive I replied sufficiently for the scope of the PR. If you feel more discussion is required for the Puppetfile, please open an issue.
https://github.com/puppetlabs/puppetlabs-peadm/pull/339/files#r1400527387 This was also responded to at the time, and I feel not something that should hold up a ticket, but be rectified in subsequent PR.
I'll try and make sure relevant discussions are properly wrapped up as we go forward
Summary
Updating node_manager to use latest Puppetlabs version
Adding rule purge to PE Infrastructure Agent
Docs to be updated and add warning around PEADM controlling PE Infrastructure Agent
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
Changes include test coverage?
Have you updated the documentation?