adds basic MFA instructions on scripts/README

puppetlabs / puppetlabs-pecdm

Puppet Bolt driven fusion of puppetlabs/peadm and Terraform.

Apache License 2.0

14 stars 19 forks source link

adds basic MFA instructions on scripts/README #35

Closed mcka1n closed 3 years ago

mcka1n commented 3 years ago

Changes

I found myself debugging why my env variables were not set correctly after running the script, I was not sure if it was an issue with my (external) Terraform template or my AWS local config.

So I'm adding this scripts/README.md to help any future autope explorer.

Bonus:

I'm introducing a new folder called scripts/ where there is a new bash script to replace the old python one to set the env variables.

mcka1n commented 3 years ago

Would it be worthwhile to also give an example configuration in ~/.aws/config and ~/.aws/credentials?

👍 @timidri on my way!

I will also remove the old /examples folder.

mcka1n commented 3 years ago

I added some changes based on your initial review @davidsandilands

This PR is ready for a 2nd review

Thanks!