puppetlabs / puppetlabs-pecdm

Puppet Bolt driven fusion of puppetlabs/peadm and Terraform.
Apache License 2.0
14 stars 19 forks source link

Composited #79

Closed ody closed 2 years ago

ody commented 2 years ago

Still needs clean up and going to do some actual documentation too but is reviewable now

ody commented 2 years ago

The goal was to adapt the internals so it was easier to break it apart if you needed to do custom things in between each step but not change the default interface and behavior for the end user. Eventually want to remove some parameters but now is not that time.

ody commented 2 years ago

I ran into a reason to either set native ssh as the default or rename the windows_runner parameter to something akin to "native_ssh", fips. The version of net-ssh in Bolt is not compatible with RHEL fips, which has disabled the ssh-rsa public key algorithm. The fix is in net-ssh 7.x but Bolt uses 6.x.

davidsandilands commented 2 years ago

Ok my adjustment doesn't run

Function Load Error for function 'pecdm::is_windows': Function Creation Error, cannot create a default dispatcher for function 'is_windows', no method with this name found (file: C:/Users/David Sandilands/PECDM environments/test_azure/plans/provision.pp, line: 127, column: 73)

davidsandilands commented 2 years ago

https://tickets.puppetlabs.com/browse/SOLARCH-1048 has been raised to follow up on the pipeline failure