search

puppetlabs / puppetlabs-postgresql

Puppet module for managing PostgreSQL
Apache License 2.0
228 stars 614 forks source link

server::database_grant: Always set default user/group and expose port as parameter #1493

Closed bastelfreak closed 1 year ago

bastelfreak commented 1 year ago

This enables us to make it configureable. When a user doesn't specify it, the defaults will be passed, without breaking existing behaviour.

bastelfreak commented 1 year ago

@ekohl It's already broken because the defined resource postgresql::server::grant has a port param with a default value and won't use $connect_settings anyways.

bastelfreak commented 1 year ago

@ekohl I could reverse the logic and always use $connect_settings when it's not empty?

bastelfreak commented 1 year ago

I made the port optional, so this should be fine now