search

puppetlabs / puppetlabs-puppet_agent

Module for managing Puppet-Agent
Apache License 2.0
41 stars 192 forks source link

(MODULES-11348) Replace lsbdistcodename with os.distro.codename #634

Closed AriaXLi closed 1 year ago

AriaXLi commented 1 year ago

This commit replaces references to lsbdistcodename with os.distro.codename. lsbdistcodename is a legacy fact that is used to determine the package name but it requires the lsb-release package. Additionally, for Puppet 8, we are moving towards dropping legacy facts. Also, since Facter 3+ provides the structured fact, os.distro.codename, users can safely upgrade from Puppet 6/7 to 8 or from Puppet 8.x to 8.y when using os.distro.codename. Due to these reasons, os.distro.codename, will be used instead of lsbdistcodename.

puppet-community-rangefinder[bot] commented 1 year ago

puppet_agent::install is a class

that may have no external impact to Forge modules.

This module is declared in 3 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

AriaXLi commented 1 year ago

This PR is based off of #596