puppetlabs / puppetlabs-puppet_agent

Module for managing Puppet-Agent
Apache License 2.0
41 stars 192 forks source link

(MODULES-11365) Enable rspec tests on Ruby 3.2 #641

Closed mhashizume closed 1 year ago

mhashizume commented 1 year ago

This PR fixes an issue with rspec tests not using keyword arguments with the override_facts helper method, which causes issues with later versions of Ruby as keyword argument behavior changes from Ruby >= 3.

This PR also replaces puppet5 tests with nightly gems with puppet8 on Ruby 3.2.

I tested these commits locally by running bundle exec rake parallel_spec on both Ruby 2.7.7 and Ruby 3.2.1.

mhashizume commented 1 year ago

Due to a misconfiguration of the puppet8 nightly gem, this PR is blocked on https://github.com/puppetlabs/puppet/pull/9030