search

puppetlabs / puppetlabs-puppet_agent

Module for managing Puppet-Agent
Apache License 2.0
41 stars 192 forks source link

(maint) Delete duplicate test #664

Closed joshcooper closed 1 year ago

joshcooper commented 1 year ago

This code was last updated in Oct 2020 and all this time we've been testing "upgrades" from 7.x to 5.5.21. This only recently started to fail when stdlib v9 was released as the root_home fact uses Ruby syntax that's not valid in Puppet 5/Ruby 2.1.9.

It's not practical to update this test after each release. And we already test idempotency in the acceptance/tests/*, so delete this test.

joshcooper commented 1 year ago

The root_home custom fact is defined here and uses syntax that's only supported in Ruby 2.3 and up:

https://github.com/puppetlabs/puppetlabs-stdlib/blob/abac8aeaa5d967691b25480a45394c2b38d447ce/lib/facter/root_home.rb#L6

tvpartytonight commented 1 year ago

I am still seeing failures, though less, when I run the changes from this branch through bundle exec rake beaker. I think we should just wait and fix them all so we can get a clean run through CI.