puppetlabs / puppetlabs-puppet_agent

Module for managing Puppet-Agent
Apache License 2.0
41 stars 192 forks source link

(maint) Update optional parameters #671

Closed mhashizume closed 11 months ago

mhashizume commented 11 months ago

As part of 404df9d all parameters in this module were assigned a data type. However, some required parameters were mistakenly classed as Optional and vice-versa.

Puppet's documentation states "If a class parameter lacks a default value, the parameter is considered required."[1]

This commit updates all parameters with default values to Optional (and whatever other relevant data type) and all parameters without default value as required. The REFERENCE.md has been updated to reflect these changes.

Additionally, this commit updates all Optional parameters be set as undef, as suggested by the optional_default puppet-lint check.

[1] https://www.puppet.com/docs/puppet/7/lang_classes#class-parameters-and-variables