search

puppetlabs / puppetlabs-puppet_agent

Module for managing Puppet-Agent
Apache License 2.0
41 stars 192 forks source link

Match allowed datatypes to yumrepo skip_if_unavailable support #672

Closed seanmil closed 11 months ago

seanmil commented 11 months ago

In PR #663 an overly strict datatype was set for the skip_if_unavailable parameter. The yumrepo type supports a variety of string values and boolean values.

seanmil commented 11 months ago

Hmm... unless I'm looking in the wrong spot the "PA" project is marked as archived and I cannot create issues there to reference in the commit message (per the error in Static Code Analysis check).

mhashizume commented 11 months ago

Thanks for this @seanmil . Since this is just a minor correction, could you add "(maint)" to the beginning of your commit summary to get it to pass the static code analysis check?

mhashizume commented 11 months ago

Ah sorry one more thing, could you regenerate REFERENCE.md with your changes? You should be able to run bundle exec puppet strings generate --format markdown --out REFERENCE.md then add the updated REFERENCE.md to your commit.

Thanks again!