(maint) Unnest module and class names in Ruby tasks

puppetlabs / puppetlabs-puppet_agent

Module for managing Puppet-Agent

Apache License 2.0

41 stars 193 forks source link

(maint) Unnest module and class names in Ruby tasks #687

Closed MartyEwings closed 7 months ago

MartyEwings commented 7 months ago

Prior to this commit a bug that had previously been resolved in :

https://github.com/puppetlabs/puppetlabs-puppet_agent/commit/2911a0a4af4255895647e20b6ca138eef93806b8

Had been reintroduced by application of rubocop recommendations.

This commit reverts this change, and also adds in the correct PDK compatible block for the cop in question so this wont happen automatically again

donoghuc commented 7 months ago

I'm confused about this, how are task acceptance tests passing? Also this only un-nests the module definitions in the task helper.

donoghuc commented 7 months ago

Ah, it appears acceptance tests cover the shell/powershell tasks not the ruby ones.

donoghuc commented 7 months ago

Ok, i see what is going on better now. This is a very annoying cop, thanks for disabling it. Seems like we could use some acceptance level testing for the ruby tasks here...