If a target of the install task does not have a which program available, but does have Puppet installed, the install task incorrectly attempts to re-install puppet.
Expected Behavior
If Puppet and its dependencies are installed correctly on a Linux target, the install task in this module should not attempt to reinstall them.
Steps to Reproduce
Install Arch Linux in a barebones/default config following the docs. In particular, install no additional packages beyond what is absolutely necessary.
Since Bolt cannot yet automate the installation of Puppet on Arch, install Puppet on Arch manually using the suggested installation procedure: pacman -S puppet.
Make sure which is not installed on the Arch target (which is the default situation of fresh installs): pacman -R which.
From a system with Bolt installed, attempt to run the install task on the Arch target: bolt task run puppet_agent::install --targets arch --log-level debug.
Observe that a failure installing puppet occurs despite Puppet already being correctly installed on the target host:
{"target":"arch","action":"task","object":"puppet_agent::install","status":"failure","value":{"_output":"20:08:19 +0000 INFO: Version parameter not defined and no agent detected. Assuming latest.\n20:08:19 +0000 INFO: Downloading Puppet latest for Arch...\n20:08:19 +0000 CRIT: Sorry Arch is not supported yet!\n","_error":{"kind":"puppetlabs.tasks/task-error","issue_code":"TASK_ERROR","msg":"The task failed with exit code 1","details":{"exit_code":1}}}}
That failure is expected: Arch is not supported by this module for Puppet installation, but there's no reason it can't be supported by this module if Puppet is already correctly installed on the target.
Environment
Bolt 3.28, running from MacOS 14.
Puppet 7.27 on ruby 3
Arch Linux installed according to the default install guide suggestions (kernel 6.7.6 as of this writing).
which is not a shell builtin or a requirement of a POSIX-compliant environment.
Surprisingly (at least to me), it's also not installed by default as a transitive or part of the core system packages on Arch, so this is less "my environment is weird for personal reasons" and more "a popular distro is ~weird~ missing a dependency of this module".
Describe the Bug
If a target of the
installtask does not have awhichprogram available, but does have Puppet installed, theinstalltask incorrectly attempts to re-install puppet.Expected Behavior
If Puppet and its dependencies are installed correctly on a Linux target, the
installtask in this module should not attempt to reinstall them.Steps to Reproduce
pacman -S puppet.whichis not installed on the Arch target (which is the default situation of fresh installs):pacman -R which.installtask on the Arch target:bolt task run puppet_agent::install --targets arch --log-level debug.That failure is expected: Arch is not supported by this module for Puppet installation, but there's no reason it can't be supported by this module if Puppet is already correctly installed on the target.
Environment
Additional Context
The failure is occurring due to this line: https://github.com/puppetlabs/puppetlabs-puppet_agent/blob/main/tasks/install_shell.sh#L147
whichis not a shell builtin or a requirement of a POSIX-compliant environment.Surprisingly (at least to me), it's also not installed by default as a transitive or part of the core system packages on Arch, so this is less "my environment is weird for personal reasons" and more "a popular distro is ~weird~ missing a dependency of this module".