puppetlabs / puppetlabs-puppet_agent

Module for managing Puppet-Agent
Apache License 2.0
41 stars 193 forks source link

Release prep v4.20.1 #719

Closed github-actions[bot] closed 1 month ago

github-actions[bot] commented 1 month ago

The previous attempt to release 4.20.0 failed, so burning the tag and prepping 4.20.1:

Automated release-prep through pdk-templates from commit 35bf03f88bb6079cc6af0abf64f9487e08e63cbe. Please verify before merging:

bastelfreak commented 1 month ago

was that raised by accident?

joshcooper commented 1 month ago

@bastelfreak the previous attempt to push 4.20.0 failed so I think I need to burn the tag, I'll update the description

bastelfreak commented 1 month ago

Please don't delete the tag or recreate it. We did that in the past and it's horrible for people that already have the tag locally. For situations like that at vox pupuli we create an issue that explains it in the title. Nice hack to get a note into the changelog. Maybe that works for you as well.

joshcooper commented 1 month ago

yeah we never delete tags or recreate them. Our changelog generator only looks at pull requests that have been merged since the last tag, so I don't know how to indicate what happened in the changelog (without making code changes).

joshcooper commented 1 month ago

@bastelfreak are you ok with this approach?

bastelfreak commented 1 month ago

Yes I think that's totally fine!

smortex commented 1 month ago

Our changelog generator only looks at pull requests that have been merged since the last tag, so I don't know how to indicate what happened in the changelog (without making code changes).

Never tried with GitHub, but maybe worth trying next time:

git commit --allow-empty

If adding a commit without change in a PR and merging it does the right thing, this should allow the ChangeLog to have some content while the code is actually unchanged (but still has the commit message that explain why this was done in the repo).