search

puppetlabs / puppetlabs-puppet_agent

Module for managing Puppet-Agent
Apache License 2.0
41 stars 193 forks source link

(PA-6627) Update the first released version for released platforms in… #726

Closed skyamgarp closed 3 weeks ago

skyamgarp commented 1 month ago

… spec

We add a new platform in 'latest_platform_list' method so that it considers builds from nightlies with the 'latest' tag before they are released (since the versioned release package won't be available for new platforms). The platforms which are no more new and have been released are removed from 'latest_platform_list' here along with their first released versions specified as needed.

We also test upgrade from the first released puppet7 version to the latest released puppet7 version. The new platforms only have one release, so this test is not applicable for them. Removed platforms which have had multiple puppet7 versions released as of now to make the test applicable for them. This is done by setting the 'multiple_puppet7_versions' parameter to true.

Tested this on local. Ad-hoc pipeline isn't available at this stage.

Updated release version according to https://perforce.atlassian.net/wiki/spaces/PUPPROD/pages/371851628/Currently+Supported+OS+Platforms

bastelfreak commented 4 weeks ago

can you elaborate a bit why you do this change?

skyamgarp commented 4 weeks ago

can you elaborate a bit why you do this change?

We add a new platform in latest_platform_list method so it should consider build from nightlies before they are released. Now as they are released I have removed them from the method.

donoghuc commented 4 weeks ago

That information belongs in the commit message. It is very unclear from the commit message what the refactor is doing.

shubhamshinde360 commented 4 weeks ago

@bastelfreak, @donoghuc Could you please take a look, added more info in the commit message. Thanks!