search

puppetlabs / puppetlabs-puppetdb

A puppet module for installing and managing puppetdb
https://forge.puppetlabs.com/puppetlabs/puppetdb
Apache License 2.0
55 stars 231 forks source link

Correct clientcert value in pg_hba.conf for Postgresql >= 12 #380

Closed jhunt-steds closed 9 months ago

jhunt-steds commented 10 months ago

12 and up, that is.

PuppetDB 8.0.0 requires Postgresql 14 or later, but starting in 12 the syntax for the clientcert option in pg_hba.conf changed. This PR implements the new syntax when a newer version of Postgresql is requested by the user.

CLAassistant commented 10 months ago

CLA assistant check
All committers have signed the CLA.

bastelfreak commented 9 months ago

@jhunt-steds thanks for the PR, can you please rebase?

jhunt-steds commented 9 months ago

Sorry, I apparently did the rebase in some wrong way that closed the PR for some reason; I'm not really a developer and don't understand git well, but it at least does apply cleanly now I think.

jhunt-steds commented 9 months ago

Apologies again, it appears I forgot to run the linter/tests after my rebase yesterday. Everything should be correct now.

jhunt-steds commented 9 months ago

Looks like the failing checks were the result of some network error rather than the changes themselves. Both contain a Ruby stack trace from the first test that has this line:

/home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/net-ssh-7.2.1/lib/net/ssh/buffered_io.rb:64:in `recv': Connection reset by peer - recvfrom(2) (Errno::ECONNRESET)