puppetlabs / puppetlabs-puppetdb

A puppet module for installing and managing puppetdb
https://forge.puppetlabs.com/puppetlabs/puppetdb
Apache License 2.0
55 stars 231 forks source link

Set data types for puppetdb parameters #411

Open chambersmp opened 6 months ago

chambersmp commented 6 months ago

Summary: Enable data type validation for parameters in puppetdb classes and defined types. The goal is to refine user inputs to reduce risk of misconfiguration or failure to apply.

Each data type was configured based on default values supplied within the params.pp class, unit/acceptance tests and alternative values recommended in PuppetDB docs.

Changes:

Potential for Breaking Change:

Related Issues: resolves #105

Testing:

h0tw1r3 commented 5 months ago

FWIW, I would remove the maintenance label so the change does show up in the change log and release notes.

chambersmp commented 4 months ago

As open_ssl_listen_port is no longer optional both params.pp and the unit test shared-examples have been updated to default to false instead of undef|nil.