search

puppetlabs / puppetlabs-release

Repo that builds packages to add our apt and yum repositories and public signing key.
7 stars 39 forks source link

Rename Amazon 7 to 2 #309

Closed joshcooper closed 3 months ago

joshcooper commented 3 months ago

Amazon 7 is an implementation detail, the actual OS is named Amazon 2

~Blocked on release of packaging gem with this change https://github.com/puppetlabs/packaging/pull/1259~

joshcooper commented 3 months ago

Should I wait until some amazon 2 packages have shipped nightly before merging this? Or does it not matter since we won't ship release packages until the next platform release?

e-gris commented 3 months ago

We ship the release package irregularly.

In other words, you can merge and then we can either ship them on demand or bunch up the changes (like the debian prefs changes) and do a release when we're ready.

joshcooper commented 3 months ago

I'm fine releasing whenever, no rush

joshcooper commented 3 months ago

I forgot to increment the version, e.g. https://github.com/puppetlabs/puppetlabs-release/pull/309/files#diff-875a97f687dfc7172649c719d7c495aba9aef896d425a20fa3647e2a8b1431b2R5

I do see nightly release packages inside each puppetN directory: https://nightlies.puppet.com/yum/puppet7-nightly/amazon/2/aarch64/puppet-agent-7.30.0.77.g8be6f291e-1.amazon2.aarch64.rpm https://nightlies.puppet.com/yum/puppet8-nightly/amazon/2/aarch64/puppet-agent-8.6.0.96.gc6c5de5b1-1.amazon2.aarch64.rpm

But not at the top-level: https://nightlies.puppet.com/yum/puppet8-nightly-release-amazon-2.noarch.rpm https://nightlies.puppet.com/yum/puppet7-nightly-release-amazon-2.noarch.rpm

Will incrementing the version and rebuilding solve that?