search

puppetlabs / puppetlabs-satellite_pe_tools

Other
2 stars 15 forks source link

DO NOT MERGE - REVIEW ONLY - Classify PE Master and SUT in NC service #25

Closed ccaum closed 8 years ago

ccaum commented 8 years ago

Previous to this commit, classification and the applicaiton of test configurations were done through a locatl Puppet apply. This is not how users are expected to use this module.

This commit puts all classification through the NC service, including a new satellite_pe_tools::acceptance class which is only intended to be used by the Beaker acceptance tests to prove applied puppet run reports are making it to the Satellite host.

Further, this commit simplifies the classification scripts by passing necessary environment variables to the scripts through beaker, leaving the puppet binary path logic in the shell script instead of the Beaker test code.

jonnytdevops commented 8 years ago

Hey Carl,

Unfortunately, these modifications cause the acceptances tests to fail, as neither the reports or facts are inside satellite.

Also, I'm not sure I quite agree about having a class inside the manifest directory that is for acceptance test use only. I think I would prefer to see this inside the test file or inside the spec directory somewhere.

I am going to create another PR with a different approach to make CI go green, whilst still using Puppet Agent.

Thanks

JT

ccaum commented 8 years ago

I liked your idea of putting the notify in site.pp. That makes sense.

As far as the reports and facts not being in satellite, that would point to a bug in the module. Running the agent on the master should configure the report processor and facts terminus.