search

puppetlabs / puppetlabs-servicenow_cmdb_integration

Other
1 stars 15 forks source link

Dry-test the servicenow.rb script in init.pp #45

Closed ekinanp closed 4 years ago

ekinanp commented 4 years ago

The dry-testing work also captured some bugs in the servicenow.rb script, namely that it doesn't properly handle error responses from ServiceNow's API.

This commit also fixes uses of apply_manifest to properly catch failures in the acceptance tests.

Resolves #44

Signed-off-by: Enis Inan enis.inan@puppet.com

puppet-community-rangefinder[bot] commented 4 years ago

servicenow_cmdb_integration is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 575 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

ekinanp commented 4 years ago

Updated to add an additional assertion that the trusted_external_command setting isn't updated if the dry test fails.