search

puppetlabs / puppetlabs-servicenow_cmdb_integration

Other
1 stars 16 forks source link

ensure of resource `puppetserver puppetconf trusted external command` should be configurable #57

Open MartyEwings opened 3 years ago

MartyEwings commented 3 years ago

https://github.com/puppetlabs/puppetlabs-servicenow_cmdb_integration/blob/7de591b3a8eefbb4a502943ea968e06582c0b661/manifests/init.pp#L107

There is no uninstall available for the module, if there is an error with the integration, and servicenow.rb does not execute catalogs fail to apply.

The resource puppetserver puppetconf trusted external command should be able to be set to "ensure absent"

albatrossflavour commented 3 years ago

Yes, please! Will make it so much easier to do demo environments if we don't have to manually unpick the snow stuff.

dbr787 commented 3 years ago

https://github.com/puppetlabs/puppetlabs-servicenow_cmdb_integration/blob/7de591b3a8eefbb4a502943ea968e06582c0b661/manifests/init.pp#L110

In addition to just present or absent, the value needs to be configurable too... In the scenario where an environment has more than one trusted external command script that needs to be executed (not just servicenow.rb), we need to specify a directory, in which all scripts will be run to generate trusted external facts.