search

puppetlabs / puppetlabs-sqlserver

PE-only Microsoft SQL module
Other
5 stars 21 forks source link

Unable to Apply SQL Server Updates when /ACTION = INSTALL #462

Closed aMeish closed 11 months ago

aMeish commented 12 months ago

Describe the Bug

When installing SQL Server, flag for [ /UpdateEnabled = FALSE ] even when our scripts set to TRUE

Expected Behavior

'UpdateEnabled' => 1: when installing SQL, any CUs provided will be applied as part of install process. Now, with updates for SQL 2022, 'UpdateEnabled' => 1 automatically defaults to 'UpdateEnabled' =>FALSE

Steps to Reproduce

We created an in-house SQL installation process using Puppet where 'UpdateEnabled' => 1 is the default for all SQL installations. I don't know Puppet well enough to explain how to reproduce the error but 'UpdateEnabled' flag can be added under sqlserver_instance::install_switches

Environment

Additional Context

In the following files, [ 'UpdateEnabled' = FALSE ] is default setting for all SQL installs:

if action == 'install'
cmd_args << '/UPDATEENABLED=False'
cmd_args << '/UPDATEENABLED=False' if action == 'install'

Can these lines be removed? If not, why were they added for v3.3.0+? Previous versions allow for 'UpdateEnabled' to be modified and the update did work successfully

jordanbreen28 commented 11 months ago

hi @aMeish - this was fixed in https://github.com/puppetlabs/puppetlabs-sqlserver/pull/466 and is awaiting release shortly. Thanks for raising this and spotting our obvious error!