(MODULES-10765) Implement public key certificate support

puppet-community-rangefinder[bot] commented 4 years ago

ssh_authorized_key is a type

Breaking changes to this file MAY impact these 88 modules (near match):

* [jtopjian-sshkeys](git@github.com/jtopjian/puppet-sshkeys.git) * [ULHPC-gpfs](https://github.com/ULHPC/puppet-gpfs) * [dhoppe-common](https://github.com/dhoppe/puppet-common.git) * [mthibaut-users](https://forge.puppet.com/mthibaut/users) * [vshn-identity](https://github.com/vshn/puppet-identity) * [codingfuture-cfweb](https://github.com/codingfuture/puppet-cfweb) * [dmcnicks-users](https://github.com/dmcnicks/dmcnicks-users) * [rnelson0-local_user](https://github.com/rnelson0/puppet-local_user) * [tedivm-hieratic](https://github.com/tedivm/puppet-hieratic) * [theforeman-foreman_simple_user](https://github.com/theforeman/puppet-foreman_simple_user) * [oris-appserver](https://bitbucket.org/oris/env-puppet-module-appserver) * [stackforge-nova](https://github.com/openstack/puppet-nova.git) * [kayak-r9util](https://github.com/kayak/puppet-r9util.git) * [puppet-amanda](https://github.com/voxpupuli/puppet-amanda.git) * [ghoneycutt-ssh](https://github.com/ghoneycutt/puppet-module-ssh.git) * [puppetlabs-opennebula](https://github.com/puppetlabs/puppetlabs-opennebula.git) * [gnubilafrance-apt_dater](https://github.com/gnubila-france/puppet-apt_dater) * [codingfuture-cftotalcontrol](https://github.com/codingfuture/puppet-cftotalcontrol) * [tampakrap-account](https://github.com/tampakrap/puppet-account) * [node13h-django](https://github.com/node13h/puppet-django) * [locp-gitssh](https://github.com/locp/gitssh) * [eirc-account](https://github.com/eirc/puppet-account) * [attachmentgenie-ssh](https://github.com/attachmentgenie/attachmentgenie-ssh) * [duxklr-manageusers](https://github.com/duxklr/manageusers) * [soli-backupninja](https://github.com/solution-libre/puppet-backupninja) * [codingfuture-cfpuppetserver](https://github.com/codingfuture/puppet-cfpuppetserver) * [box-clusterrunner](https://github.com/box/puppet-clusterrunner) * [glorpen-g_server](https://github.com/glorpen/puppet-g_server.git) * [example42-psick](https://github.com/example42/puppet-psick) * [xdrum-ssh](https://github.com/x-drum/puppet-ssh) * [spjmurray-puppetdeploy](https://github.com/spjmurray/puppet-puppetdeploy) * [torrancew-account](https://github.com/torrancew/puppet-account) * [tompurl-rbpod](https://github.com/tompurl/puppet-rbpod) * [evenup-common](https://github.com/evenup/evenup-common) * [pltraining-classroom_legacy](https://github.com/puppetlabs/pltraining-classroom_legacy) * [rberwald-accounts](https://github.com/rberwald/rberwald-accounts) * [siliconfrog-rsa_keys](https://github.com/valeriominetti/siliconfrog-rsakeys.git) * [trovit-mha](https://github.com/trovitsys/puppet-mha.git) * [treydock-root](https://github.com/treydock/puppet-module-root) * [davehewy-users](https://github.com/DaveHewy/puppet-users) * [desalvo-users](https://github.com/desalvo/puppet-users) * [puppetfinland-rsnapshot](https://github.com/Puppet-Finland/puppet-rsnapshot.git) * [codingfuture-cfsystem](https://github.com/codingfuture/puppet-cfsystem) * [example42-apt](https://github.com/example42/puppet-apt) * [gabe-ansible](https://github.com/gabe-sky/puppet-ansible) * [jethrocarr-virtual_user](https://github.com/jethrocarr/puppet-virtual_user) * [smash-backupninja](https://gitlab.com/shared-puppet-modules-group/backupninja) * [ceritsc-perun](https://github.com/CERIT-SC/puppet-perun.git) * [codingfuture-cfauth](https://github.com/codingfuture/puppet-cfauth) * [deric-barman](https://github.com/deric/puppet-barman.git) * [theforeman-foreman_proxy](https://github.com/theforeman/puppet-foreman_proxy) * [thias-ovh](https://github.com/thias/puppet-ovh) * [qtechnologies-local_users](https://github.com/Q-Technologies/puppet-local_users.git) * [deric-accounts](https://github.com/deric/puppet-accounts) * [ghoneycutt-common](https://github.com/ghoneycutt/puppet-module-common.git) * [camptocamp-ssh](https://github.com/camptocamp/puppet-ssh) * [wyrie-backuppc](https://bitbucket.org/wyrie/puppet-backuppc/src) * [sidorenko-sshkeys](https://github.com/fraenki/puppet-sshkeys/) * [dhgwilliam-dynenv](https://forge.puppet.com/dhgwilliam/dynenv) * [simp-simp](https://github.com/simp/pupmod-simp-simp) * [fraenki-sshkeys](https://github.com/fraenki/puppet-sshkeys/) * [enterprisemodules-ora_rac](http:/www.github.com/enterprisemodules/ora_rac) * [mthibaut-mutual_trust](https://forge.puppet.com/mthibaut/mutual_trust) * [gnubilafrance-backupninja](https://github.com/gnubila-france/puppet-backupninja) * [stackstorm-st2](https://github.com/StackStorm/puppet-st2) * [ivaldi-rsnapshot](https://github.com/ivaldi/ivaldi-rsnapshot) * [enterprisemodules-wls_profile](https://github.com/enterprisemodules/wls_profile) * [hfm-mha](https://github.com/hfm/puppet-mha.git) * [treydock-gpfs](https://github.com/treydock/puppet-module-gpfs) * [continuent-tungsten](https://github.com/continuent/continuent-tungsten) * [nvogel-ansible](https://github.com/nvogel/puppet-ansible) * [Aethylred-keymaster](https://github.com/Aethylred/puppet-keymaster) * [puppetlabs-accounts](https://github.com/puppetlabs/puppetlabs-accounts) * [themeier-ssh](https://github.com/themeier/puppet-module-ssh.git) * [maany-simple_grid](https://github.com/WLCG-Lightweight-Sites/simple_grid_puppet_module) * [simp-simp_bolt](https://github.com/simp/pupmod-simp-simp_bolt) * [delphix-delphix](https://github.com/delphix/puppet) * [maxadamo-zfs_nas](https://github.com/maxadamo/zfs_nas) * [ffollonier-manage_accounts](https://github.com/ffollonier/manage_accounts) * [opentable-homes](https://github.com/opentable/puppet-homes.git) * [olevole-ssh](https://github.com/olevole/puppet-module-ssh.git) * [camptocamp-accounts](https://github.com/camptocamp/puppet-accounts.git) * [openstack-nova](https://github.com/openstack/puppet-nova.git) * [pdxcat-amanda](https://github.com/pdxcat/puppet-module-amanda) * [it2ndq-barman](https://github.com/2ndquadrant-it/puppet-barman.git) * [ULHPC-backuppc](https://github.com/ULHPC/puppet-backuppc) * [jlondon-githubkey](https://github.com/justicel/puppet-githubkey.git) * [simp-ssh](https://github.com/simp/pupmod-simp-ssh)

This module is declared in 5 of 575 indexed public `Puppetfiles`.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

bastelfreak commented 4 years ago

I went ahead and implemented all types from https://raw.githubusercontent.com/openssh/openssh-portable/master/PROTOCOL.certkeys

puppet-community-rangefinder[bot] commented 4 years ago

ssh_authorized_key is a type

Breaking changes to this file MAY impact these 88 modules (near match):

* [jtopjian-sshkeys](git@github.com/jtopjian/puppet-sshkeys.git) * [ULHPC-gpfs](https://github.com/ULHPC/puppet-gpfs) * [dhoppe-common](https://github.com/dhoppe/puppet-common.git) * [mthibaut-users](https://forge.puppet.com/mthibaut/users) * [vshn-identity](https://github.com/vshn/puppet-identity) * [codingfuture-cfweb](https://github.com/codingfuture/puppet-cfweb) * [dmcnicks-users](https://github.com/dmcnicks/dmcnicks-users) * [rnelson0-local_user](https://github.com/rnelson0/puppet-local_user) * [tedivm-hieratic](https://github.com/tedivm/puppet-hieratic) * [theforeman-foreman_simple_user](https://github.com/theforeman/puppet-foreman_simple_user) * [oris-appserver](https://bitbucket.org/oris/env-puppet-module-appserver) * [stackforge-nova](https://github.com/openstack/puppet-nova.git) * [kayak-r9util](https://github.com/kayak/puppet-r9util.git) * [puppet-amanda](https://github.com/voxpupuli/puppet-amanda.git) * [ghoneycutt-ssh](https://github.com/ghoneycutt/puppet-module-ssh.git) * [puppetlabs-opennebula](https://github.com/puppetlabs/puppetlabs-opennebula.git) * [gnubilafrance-apt_dater](https://github.com/gnubila-france/puppet-apt_dater) * [codingfuture-cftotalcontrol](https://github.com/codingfuture/puppet-cftotalcontrol) * [tampakrap-account](https://github.com/tampakrap/puppet-account) * [node13h-django](https://github.com/node13h/puppet-django) * [locp-gitssh](https://github.com/locp/gitssh) * [eirc-account](https://github.com/eirc/puppet-account) * [attachmentgenie-ssh](https://github.com/attachmentgenie/attachmentgenie-ssh) * [duxklr-manageusers](https://github.com/duxklr/manageusers) * [soli-backupninja](https://github.com/solution-libre/puppet-backupninja) * [codingfuture-cfpuppetserver](https://github.com/codingfuture/puppet-cfpuppetserver) * [box-clusterrunner](https://github.com/box/puppet-clusterrunner) * [glorpen-g_server](https://github.com/glorpen/puppet-g_server.git) * [example42-psick](https://github.com/example42/puppet-psick) * [xdrum-ssh](https://github.com/x-drum/puppet-ssh) * [spjmurray-puppetdeploy](https://github.com/spjmurray/puppet-puppetdeploy) * [torrancew-account](https://github.com/torrancew/puppet-account) * [tompurl-rbpod](https://github.com/tompurl/puppet-rbpod) * [evenup-common](https://github.com/evenup/evenup-common) * [pltraining-classroom_legacy](https://github.com/puppetlabs/pltraining-classroom_legacy) * [rberwald-accounts](https://github.com/rberwald/rberwald-accounts) * [siliconfrog-rsa_keys](https://github.com/valeriominetti/siliconfrog-rsakeys.git) * [trovit-mha](https://github.com/trovitsys/puppet-mha.git) * [treydock-root](https://github.com/treydock/puppet-module-root) * [davehewy-users](https://github.com/DaveHewy/puppet-users) * [desalvo-users](https://github.com/desalvo/puppet-users) * [puppetfinland-rsnapshot](https://github.com/Puppet-Finland/puppet-rsnapshot.git) * [codingfuture-cfsystem](https://github.com/codingfuture/puppet-cfsystem) * [example42-apt](https://github.com/example42/puppet-apt) * [gabe-ansible](https://github.com/gabe-sky/puppet-ansible) * [jethrocarr-virtual_user](https://github.com/jethrocarr/puppet-virtual_user) * [smash-backupninja](https://gitlab.com/shared-puppet-modules-group/backupninja) * [ceritsc-perun](https://github.com/CERIT-SC/puppet-perun.git) * [codingfuture-cfauth](https://github.com/codingfuture/puppet-cfauth) * [deric-barman](https://github.com/deric/puppet-barman.git) * [theforeman-foreman_proxy](https://github.com/theforeman/puppet-foreman_proxy) * [thias-ovh](https://github.com/thias/puppet-ovh) * [qtechnologies-local_users](https://github.com/Q-Technologies/puppet-local_users.git) * [deric-accounts](https://github.com/deric/puppet-accounts) * [ghoneycutt-common](https://github.com/ghoneycutt/puppet-module-common.git) * [camptocamp-ssh](https://github.com/camptocamp/puppet-ssh) * [wyrie-backuppc](https://bitbucket.org/wyrie/puppet-backuppc/src) * [sidorenko-sshkeys](https://github.com/fraenki/puppet-sshkeys/) * [dhgwilliam-dynenv](https://forge.puppet.com/dhgwilliam/dynenv) * [simp-simp](https://github.com/simp/pupmod-simp-simp) * [fraenki-sshkeys](https://github.com/fraenki/puppet-sshkeys/) * [enterprisemodules-ora_rac](http:/www.github.com/enterprisemodules/ora_rac) * [mthibaut-mutual_trust](https://forge.puppet.com/mthibaut/mutual_trust) * [gnubilafrance-backupninja](https://github.com/gnubila-france/puppet-backupninja) * [stackstorm-st2](https://github.com/StackStorm/puppet-st2) * [ivaldi-rsnapshot](https://github.com/ivaldi/ivaldi-rsnapshot) * [enterprisemodules-wls_profile](https://github.com/enterprisemodules/wls_profile) * [hfm-mha](https://github.com/hfm/puppet-mha.git) * [treydock-gpfs](https://github.com/treydock/puppet-module-gpfs) * [continuent-tungsten](https://github.com/continuent/continuent-tungsten) * [nvogel-ansible](https://github.com/nvogel/puppet-ansible) * [Aethylred-keymaster](https://github.com/Aethylred/puppet-keymaster) * [puppetlabs-accounts](https://github.com/puppetlabs/puppetlabs-accounts) * [themeier-ssh](https://github.com/themeier/puppet-module-ssh.git) * [maany-simple_grid](https://github.com/WLCG-Lightweight-Sites/simple_grid_puppet_module) * [simp-simp_bolt](https://github.com/simp/pupmod-simp-simp_bolt) * [delphix-delphix](https://github.com/delphix/puppet) * [maxadamo-zfs_nas](https://github.com/maxadamo/zfs_nas) * [ffollonier-manage_accounts](https://github.com/ffollonier/manage_accounts) * [opentable-homes](https://github.com/opentable/puppet-homes.git) * [olevole-ssh](https://github.com/olevole/puppet-module-ssh.git) * [camptocamp-accounts](https://github.com/camptocamp/puppet-accounts.git) * [openstack-nova](https://github.com/openstack/puppet-nova.git) * [pdxcat-amanda](https://github.com/pdxcat/puppet-module-amanda) * [it2ndq-barman](https://github.com/2ndquadrant-it/puppet-barman.git) * [ULHPC-backuppc](https://github.com/ULHPC/puppet-backuppc) * [jlondon-githubkey](https://github.com/justicel/puppet-githubkey.git) * [simp-ssh](https://github.com/simp/pupmod-simp-ssh)

This module is declared in 5 of 575 indexed public `Puppetfiles`.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

bastelfreak commented 4 years ago

I tested this also in my own environment and can verify that this doesn't break anymore if such keys are present on the system.

bastelfreak commented 4 years ago

ping :)

puppet-community-rangefinder[bot] commented 4 years ago

ssh_authorized_key is a type

Breaking changes to this file MAY impact these 88 modules (near match):

* [puppetlabs-opennebula](https://github.com/puppetlabs/puppetlabs-opennebula.git) * [ULHPC-backuppc](https://github.com/ULHPC/puppet-backuppc) * [jethrocarr-virtual_user](https://github.com/jethrocarr/puppet-virtual_user) * [xdrum-ssh](https://github.com/x-drum/puppet-ssh) * [gnubilafrance-apt_dater](https://github.com/gnubila-france/puppet-apt_dater) * [ULHPC-gpfs](https://github.com/ULHPC/puppet-gpfs) * [theforeman-foreman_simple_user](https://github.com/theforeman/puppet-foreman_simple_user) * [tampakrap-account](https://github.com/tampakrap/puppet-account) * [dhgwilliam-dynenv](https://forge.puppet.com/dhgwilliam/dynenv) * [simp-simp_bolt](https://github.com/simp/pupmod-simp-simp_bolt) * [delphix-delphix](https://github.com/delphix/puppet) * [trovit-mha](https://github.com/trovitsys/puppet-mha.git) * [davehewy-users](https://github.com/DaveHewy/puppet-users) * [box-clusterrunner](https://github.com/box/puppet-clusterrunner) * [tompurl-rbpod](https://github.com/tompurl/puppet-rbpod) * [locp-gitssh](https://github.com/locp/gitssh) * [node13h-django](https://github.com/node13h/puppet-django) * [siliconfrog-rsa_keys](https://github.com/valeriominetti/siliconfrog-rsakeys.git) * [desalvo-users](https://github.com/desalvo/puppet-users) * [maxadamo-zfs_nas](https://github.com/maxadamo/zfs_nas) * [eirc-account](https://github.com/eirc/puppet-account) * [ffollonier-manage_accounts](https://github.com/ffollonier/manage_accounts) * [thias-ovh](https://github.com/thias/puppet-ovh) * [ivaldi-rsnapshot](https://github.com/ivaldi/ivaldi-rsnapshot) * [gnubilafrance-backupninja](https://github.com/gnubila-france/puppet-backupninja) * [Aethylred-keymaster](https://github.com/Aethylred/puppet-keymaster) * [soli-backupninja](https://github.com/solution-libre/puppet-backupninja) * [tedivm-hieratic](https://github.com/tedivm/puppet-hieratic) * [treydock-gpfs](https://github.com/treydock/puppet-module-gpfs) * [example42-psick](https://github.com/example42/puppet-psick) * [enterprisemodules-wls_profile](https://github.com/enterprisemodules/wls_profile) * [sidorenko-sshkeys](https://github.com/fraenki/puppet-sshkeys/) * [fraenki-sshkeys](https://github.com/fraenki/puppet-sshkeys/) * [ceritsc-perun](https://github.com/CERIT-SC/puppet-perun.git) * [torrancew-account](https://github.com/torrancew/puppet-account) * [spjmurray-puppetdeploy](https://github.com/spjmurray/puppet-puppetdeploy) * [gabe-ansible](https://github.com/gabe-sky/puppet-ansible) * [duxklr-manageusers](https://github.com/duxklr/manageusers) * [rberwald-accounts](https://github.com/rberwald/rberwald-accounts) * [opentable-homes](https://github.com/opentable/puppet-homes.git) * [pdxcat-amanda](https://github.com/pdxcat/puppet-module-amanda) * [mthibaut-mutual_trust](https://forge.puppet.com/mthibaut/mutual_trust) * [dmcnicks-users](https://github.com/dmcnicks/dmcnicks-users) * [camptocamp-ssh](https://github.com/camptocamp/puppet-ssh) * [jlondon-githubkey](https://github.com/justicel/puppet-githubkey.git) * [evenup-common](https://github.com/evenup/evenup-common) * [continuent-tungsten](https://github.com/continuent/continuent-tungsten) * [codingfuture-cfauth](https://github.com/codingfuture/puppet-cfauth) * [dhoppe-common](https://github.com/dhoppe/puppet-common.git) * [codingfuture-cfpuppetserver](https://github.com/codingfuture/puppet-cfpuppetserver) * [codingfuture-cftotalcontrol](https://github.com/codingfuture/puppet-cftotalcontrol) * [codingfuture-cfsystem](https://github.com/codingfuture/puppet-cfsystem) * [codingfuture-cfweb](https://github.com/codingfuture/puppet-cfweb) * [qtechnologies-local_users](https://github.com/Q-Technologies/puppet-local_users.git) * [stackstorm-st2](https://github.com/StackStorm/puppet-st2) * [pltraining-classroom_legacy](https://github.com/puppetlabs/pltraining-classroom_legacy) * [ghoneycutt-common](https://github.com/ghoneycutt/puppet-module-common.git) * [wyrie-backuppc](https://bitbucket.org/wyrie/puppet-backuppc/src) * [deric-accounts](https://github.com/deric/puppet-accounts) * [puppetfinland-rsnapshot](https://github.com/Puppet-Finland/puppet-rsnapshot.git) * [enterprisemodules-ora_rac](http:/www.github.com/enterprisemodules/ora_rac) * [rnelson0-local_user](https://github.com/rnelson0/puppet-local_user) * [it2ndq-barman](https://github.com/2ndquadrant-it/puppet-barman.git) * [jtopjian-sshkeys](git@github.com/jtopjian/puppet-sshkeys.git) * [hfm-mha](https://github.com/hfm/puppet-mha.git) * [deric-barman](https://github.com/deric/puppet-barman.git) * [example42-apt](https://github.com/example42/puppet-apt) * [glorpen-g_server](https://github.com/glorpen/puppet-g_server.git) * [oris-appserver](https://bitbucket.org/oris/env-puppet-module-appserver) * [attachmentgenie-ssh](https://github.com/attachmentgenie/attachmentgenie-ssh) * [nvogel-ansible](https://github.com/nvogel/puppet-ansible) * [puppet-amanda](https://github.com/voxpupuli/puppet-amanda.git) * [themeier-ssh](https://github.com/themeier/puppet-module-ssh.git) * [smash-backupninja](https://gitlab.com/shared-puppet-modules-group/backupninja) * [treydock-root](https://github.com/treydock/puppet-module-root) * [vshn-identity](https://github.com/vshn/puppet-identity) * [stackforge-nova](https://github.com/openstack/puppet-nova.git) * [puppetlabs-accounts](https://github.com/puppetlabs/puppetlabs-accounts) * [simp-ssh](https://github.com/simp/pupmod-simp-ssh) * [kayak-r9util](https://github.com/kayak/puppet-r9util.git) * [mthibaut-users](https://forge.puppet.com/mthibaut/users) * [maany-simple_grid](https://github.com/WLCG-Lightweight-Sites/simple_grid_puppet_module) * [camptocamp-accounts](https://github.com/camptocamp/puppet-accounts.git) * [theforeman-foreman_proxy](https://github.com/theforeman/puppet-foreman_proxy) * [openstack-nova](https://github.com/openstack/puppet-nova.git) * [olevole-ssh](https://github.com/olevole/puppet-module-ssh.git) * [ghoneycutt-ssh](https://github.com/ghoneycutt/puppet-module-ssh.git) * [simp-simp](https://github.com/simp/pupmod-simp-simp)

This module is declared in 5 of 575 indexed public `Puppetfiles`.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

bastelfreak commented 4 years ago

Hi people. I notice that there are no code owners defined here. Is this on purpose or was that missed? I thought all maintained Puppet repos now have that.

GabrielNagy commented 4 years ago

There is a codeowners file https://github.com/puppetlabs/puppetlabs-sshkeys_core/blob/main/CODEOWNERS so a review request should have been triggered, I'm not sure why it didn't happen.

GabrielNagy commented 4 years ago

PR looks good :+1:, thanks for the contribution!

bastelfreak commented 4 years ago

@GabrielNagy could you kick off a new release soonish?

GabrielNagy commented 4 years ago

sure @bastelfreak, as it happens we already have the release ticket in our sprint 😄 gonna jump on it

puppetlabs / puppetlabs-sshkeys_core