search

puppetlabs / puppetlabs-stdlib

Puppet Labs Standard Library module
http://forge.puppetlabs.com/puppetlabs/stdlib
Apache License 2.0
348 stars 580 forks source link

Add `use_strict_setting` parameter to `deprecation` function #1378

Closed alexjfisher closed 1 year ago

alexjfisher commented 1 year ago

In this change, an optional third parameter is added to the deprecation function. The default behaviour remains the same, but when the third parameter is set to false, Puppet's strict setting is ignored. This means that even if strict is set to error, no exception will be raised when this function is called, and a warning will be logged instead.

This is a prerequisite for #1373

chelnak commented 1 year ago

Are the acceptance tests expected?

alexjfisher commented 1 year ago

Are the acceptance tests expected

@chelnak Sorry, not following. How do you mean? Are you referring to the failing tests that github is highlighting? (If so, I think those are all the tests marked as pending and unrelated)

chelnak commented 1 year ago

Ha! I was trying to multitask and failed.

Yes I was referring to the failed test. It's unusual for a pending test to make the run red.

Can you just double check it?

alexjfisher commented 1 year ago

Ha! I was trying to multitask and failed.

Yes I was referring to the failed test. It's unusual for a pending test to make the run red.

Which failed test? I can't see any that are red.

chelnak commented 1 year ago

I think it was transient! I re-kicked the failed one and it's green now.

alexjfisher commented 1 year ago

I think it was transient! I re-kicked the failed one and it's green now.

ah, thanks. That makes more sense now. Thought one of us was seeing things! :)