search

puppetlabs / puppetlabs-vcsrepo

Support for source control repositories
http://forge.puppetlabs.com/puppetlabs/vcsrepo
GNU General Public License v2.0
223 stars 285 forks source link

(GH-545) Raise if identity is used with older git #551

Closed chelnak closed 2 years ago

chelnak commented 2 years ago

The SSH implementation in this module relies on the GIT_SSH_COMMAND environment variable. This option is only available in versions 2.10.0 and later of Git.

Therefore in in certain cases when consumers have an older version of git installed the module will fail but would lack a descriptive error message.

This PR ensures that we check the git version when the identity parameter is used and raising a descriptive error if the current version is lower than 2.10.0.

Fixes #545

puppet-community-rangefinder[bot] commented 2 years ago

vcsrepo is a type

Breaking changes to this file WILL impact these 174 modules (exact match): * [southernhill-phpldapadmin](https://github.com/southernhill/puppet-phpldapadmin.git) * [jbussdieker-whisper](http://github.com/jbussdieker/puppet-whisper) * [frankcarey-yeoman](https://github.com/frankcarey/puppet-yeoman) * [Siebjee-python](https://bitbucket.org/ownbaws/python/src) * [jgazeley-nagios](https://github.com/djjudas21/puppet-nagios) * [smithyuk-ec2_snapshot](https://github.com/smithyuk/puppet-ec2_snapshot) * [brwyatt-vim](https://github.com/brwyatt/puppet-vim) * [rehan-easyrsa](https://github.com/rehanone/puppet-easyrsa.git) * [rehan-tmux](https://github.com/rehanone/puppet-tmux.git) * [treydock-nhc](https://github.com/treydock/puppet-module-nhc) * [conzar-ckan](https://bitbucket.org/landcareresearch/puppet-ckan.git) * [brainsware-wintersmith](https://github.com/Brainsware/puppet-wintersmith) * [puppet-mrepo](https://github.com/voxpupuli/puppet-mrepo) * [shr3kst3r-glacier](https://github.com/shr3kst3r/glacier.git) * [huit-gitolite](https://forge.puppet.com/huit/gitolite) * [puppet-ferm](https://github.com/voxpupuli/puppet-ferm.git) * [pltraining-quest](https://github.com/puppetlabs/pltraining-quest) * [spotify-talos](https://github.com/spotify/puppet-talos) * [glarizza-osx_management](http://forge.puppetlabs.com/glarizza/osx_management) * [nnutter-testdb](https://github.com/genome/nnutter-testdb) * [zivtech-drush](https://github.com/zivtech/puppet-drush.git) * [rcoleman-octopress](https://github.com/rcoleman/puppet-octopress.git) * [garethr-kibana](https://forge.puppet.com/garethr/kibana) * [vormetriclabs-meteor](https://github.com/vormetriclabs/puppet-meteor.git) * [daenney-pyenv](https://github.com/daenney/puppet-pyenv.git) * [velaluqa-phpmyadmin](https://github.com/velaluqa/puppet-phpmyadmin) * [geoffwilliams-r_profile](https://github.com/GeoffWilliams/r_profile) * [zoni-err](https://forge.puppet.com/zoni/err) * [velaluqa-phppgadmin](https://github.com/velaluqa/puppet-phppgadmin) * [mcenturion-mhn_cowrie](https://github.com/marcocen/mhn_cowrie) * [lukrop-antigen](https://github.com/lukrop/puppet-lukrop-antigen.git) * [millerjl1701-pulsar](https://github.com/millerjl1701/millerjl1701-pulsar) * [adullact-fusionforge](https://gitlab.adullact.net/adullact/puppet-fusionforge.git) * [rafaelfc-phpqatools](https://github.com/rafaelfelix/puppet-phpqatools.git) * [puppetfinland-patchwork](https://github.com/Puppet-Finland/puppet-patchwork.git) * [danzilio-letsencrypt](https://github.com/danzilio/puppet-letsencrypt) * [garethr-wackopicko](https://github.com/garethr/garethr-wackopicko.git) * [jgazeley-galera_innoptimizer](https://github.com/djjudas21/puppet-galera-innoptimizer) * [othalla-tautulli](https://github.com/othalla/puppet-tautulli) * [opentable-nagdash](https://github.com/opentable/puppet-nagdash) * [thekevjames-neovim](https://github.com/TheKevJames/puppet-neovim) * [oris-appserver](https://bitbucket.org/oris/env-puppet-module-appserver) * [fraenki-acme](https://github.com/fraenki/puppet-acme) * [justinstoller-ruby_build](https://github.com/justinstoller/puppet-ruby_build) * [driebit-zotonic](https://github.com/driebit/puppet-zotonic.git) * [halyard-acme](https://github.com/halyard/puppet-acme) * [mayflower-prosody](https://github.com/mayflower/puppet-prosody) * [Aethylred-puppetdashboard](https://github.com/Aethylred/puppet-puppetdashboard) * [stackforge-tempest](https://github.com/openstack/puppet-tempest.git) * [pauloconnor-doorman](https://github.com/pauloconnor/pauloconnor-doorman.git) * [mricon-bugzilla](https://github.com/mricon/puppet-bugzilla) * [dhgwilliam-dynenv](https://forge.puppet.com/dhgwilliam/dynenv) * [shanemadden-redis_multinode](https://github.com/shanemadden/shanemadden-redis_multinode.git) * [ncorrare-pe_slack_bot](https://github.com/ncorrare/ncorrare-pe_slack_bot) * [jesse-pe_nc_backup](https://github.com/jessereynolds/puppet-pe_nc_backup) * [knoppi-jitsi](https://github.com/knoppi/puppet-jitsi) * [joshsouza-stagecoach](https://github.com/joshsouza/puppet-stagecoach.git) * [pdxcat-leonardo](https://github.com/pdxcat/puppet-module-leonardo) * [baurmatt-codimd](https://github.com/baurmatt/puppet-codimd) * [eirikur-dotfiles](https://github.com/eirikur-ari/puppet-dotfiles) * [jlondon-surrogate](https://github.com/justicel/puppet-surrogate.git) * [ajmaidak-ttrss](https://github.com/ajmaidak/puppet-ttrss) * [Aethylred-ck](https://github.com/Aethylred/puppet-ck) * [mcenturion-mhn_dionaea](https://github.com/marcocen/mhn_dionaea) * [jconway-opengrok](https://github.com/jordanconway/puppet-opengrok) * [halyard-dotfiles](https://github.com/halyard/puppet-dotfiles) * [jlk-wizardvan](https://github.com/jlk/puppet-wizardvan) * [jgazeley-sqlmap](https://github.com/djjudas21/puppet-sqlmap) * [bzed-dehydrated](https://github.com/bzed/bzed-dehydrated) * [asancheza-assimp](https://github.com/assimp/assimp) * [eshamow-prosody](https://github.com/mayflower/puppet-prosody) * [maasch-iot_provisioning](https://github.com/TomWieschalla/Masterprojekt-WS15-16-MMI-IoT) * [chedi-django](https://github.com/Chedi/django-puppet) * [Ziaunys-tessera](https://github.com/Ziaunys/puppet-tessera) * [puppetlabs-mrepo](https://github.com/puppetlabs/puppetlabs-mrepo.git) * [ayohrling-r10k](https://github.com/ayohrling/r10k) * [maxadamo-sensu_web](https://github.com/maxadamo/sensu_web) * [cheasles-rhasspy](https://github.com/cheasles/puppet-rhasspy.git) * [puppetfinland-atlassiancloud](https://github.com/Puppet-Finland/puppet-atlassiancloud.git) * [bzed-letsencrypt](https://github.com/bzed/bzed-letsencrypt) * [jsnshrmn-twlight](https://github.com/WikipediaLibrary/twlight_puppet) * [huskycode-vim](https://github.com/huskycode/puppet-huskycode-vim) * [gbrown-vcs_deploy](https://forge.puppet.com/gbrown/vcs_deploy) * [gajdaw-composer_install](https://github.com/puppet-by-examples/puppet-composer_install) * [jay-letschat](https://github.com/mootpt/letschat-module) * [luckyknight-hhvm](https://github.com/craigcarnell/puppet-hhvm.git) * [jstocks-pcp_broker](https://github.com/james-stocks/puppet-pcp-broker) * [adcade-statsd](https://forge.puppet.com/adcade/statsd) * [puppet-etherpad](https://github.com/voxpupuli/puppet-etherpad) * [icinga-icingaweb2](https://github.com/Icinga/puppet-icingaweb2) * [gajdaw-bundle_install](https://github.com/puppet-by-examples/puppet-bundle_install) * [Lavaburn-cabot](https://github.com/Lavaburn/puppet_cabot.git) * [signalfx-collectd](https://github.com/signalfx/puppet_collectd) * [thejandroman-grafana](https://github.com/thejandroman/puppet-grafana) * [gajdaw-phpmyadmin](https://github.com/puppet-by-examples/puppet-phpmyadmin) * [jpadams-puppet_vim_env](https://github.com/jpadams/puppet_vim_env) * [zack-r10k](https://github.com/acidprime/r10k) * [edgester-buildbot](https://forge.puppet.com/edgester/buildbot) * [theias-filelocker](https://github.com/theias/theias-filelocker.git) * [pltraining-classroom](https://github.com/puppetlabs/pltraining-classroom) * [openstack-tempest](https://opendev.org/openstack/puppet-tempest.git) * [halyard-sdr](https://github.com/halyard/puppet-sdr) * [af6140-wal_e](https://github.com/af6140/puppet_wal_e) * [puppet-puppetboard](https://github.com/voxpupuli/puppet-puppetboard.git) * [landcareresearch-amazon_s3](https://bitbucket.org/landcareresearch/puppet-amazon-s3) * [garethr-tasseo](https://forge.puppet.com/garethr/tasseo) * [tedivm-ghebackups](https://github.com/tedivm/puppet-ghebackups) * [scottyc-docker_swarm](https://github.com/scotty-c/puppet-docker_swarm) * [techdad-acme_sh](https://github.com/techdad/puppet-acme_sh) * [edestecd-software](https://github.com/edestecd/puppet-software.git) * [nibalizer-puppetboard](https://github.com/nibalizer/puppet-module-puppetboard.git) * [adullact-demarchessimplifiees](https://gitlab.adullact.net/demarches-simplifiees/puppet-demarchessimplifiees.git) * [jbussdieker-graphite_web](http://github.com/jbussdieker/puppet-graphite_web) * [bramwelt-patchwork](https://github.com/bramwelt/puppet-patchwork) * [ULHPC-bash](https://github.com/ULHPC/puppet-bash) * [meldsza-discourse_deploy](https://github.com/meldsza/discourse_deploy) * [puppetfinland-pwm](https://github.com/Puppet-Finland/puppet-pwm.git) * [isomodvarac-exercise](https://github.com/isomodvarac/exercise) * [gerardkok-reposado](https://github.com/gerardkok/puppet-reposado.git) * [datacentred-nfsen](https://github.com/datacentred/puppet-nfsen) * [appuio-openshift](https://github.com/appuio/puppet-openshift) * [joshuaspence-phabricator](https://github.com/joshuaspence/puppet-phabricator) * [bfraser-gdash](https://github.com/bfraser/puppet-gdash.git) * [thexa4-secrets_server](https://github.com/thexa4/puppet-secret_server) * [ULHPC-ganglia](https://github.com/ULHPC/puppet-ganglia) * [groupbuddies-gb](https://github.com/groupbuddies/gb-puppet/tree/master/puppet-module) * [pltraining-selfpaced](https://github.com/puppetlabs/pltraining-selfpaced) * [ajsmith-riemann](https://github.com/ajsmith/puppet-riemann.git) * [puppet-prosody](https://github.com/voxpupuli/puppet-prosody) * [tykeal-jjb](https://github.com/tykeal/puppet-jjb.git) * [jbussdieker-carbon](http://github.com/jbussdieker/puppet-carbon) * [pgassmann-letsencrypt](https://github.com/pgassmann/puppet-letsencrypt) * [monkygames-beansbooks](https://bitbucket.org/monkygames/puppet-beansbooks.git) * [adullact-ssp](https://gitlab.adullact.net/adullact/puppet-ssp.git) * [sergk-tfenv](https://github.com/SergK/puppet-tfenv) * [waymilky-vim_puppet](https://github.com/prabin5/vim_puppet.git) * [natewalck-munki_appliance](https://forge.puppet.com/natewalck/munki_appliance) * [Aethylred-apaxy](https://github.com/Aethylred/puppet-apaxy) * [eshamow-gitolite](https://github.com/eshamow/eshamow-gitolite.git) * [rchrd2-dokku](https://github.com/rchrd2/puppet-dokku) * [firm1-zds](https://github.com/firm1/zds-puppet) * [cvquesty-puppetdev](https://github.com/cvquesty/puppetdev) * [eschiller-trac](https://www.github.com/eschiller/puppet-trac) * [call-workstation](https://github.com/call/call-workstation) * [icann-webapp](https://github.com/icann-dns/puppet-webapp) * [rehan-ohmyzsh](https://github.com/rehanone/puppet-ohmyzsh.git) * [sgnl05-racktables](https://github.com/sgnl05/sgnl05-racktables.git) * [serverascode-saio](https://forge.puppet.com/serverascode/saio) * [opuscodium-taiga](https://github.com/opus-codium/puppet-taiga) * [osc-openondemand](https://github.com/osc/puppet-module-openondemand) * [lyonliang-otrs](https://github.com/ChinaShrimp/puppet-lyonliang-otrs.git) * [lboynton-gitlab](https://github.com/lboynton/puppet-gitlab) * [thekevjames-jasper](https://github.com/TheKevJames/puppet-jasper) * [justintw-developer_environment](https://github.com/JustinTW/justintw-developer_environment) * [thejandroman-kibana3](https://github.com/thejandroman/puppet-kibana3) * [halyard-asdf](https://github.com/halyard/puppet-asdf) * [Aethylred-gitlab](https://github.com/Aethylred/puppet-gitlab) * [halyard-homebrew](https://github.com/halyard/puppet-homebrew) * [velaluqa-redmine](https://github.com/velaluqa/puppet-redmine) * [lboynton-ejabberd](https://github.com/lboynton/puppet-ejabberd) * [mtsinc1-trac](https://www.github.com/mtsinc1/puppet-trac) * [johanek-redmine](https://github.com/johanek/johanek-redmine) * [thekevjames-phabricator](https://github.com/TheKevJames/puppet-phabricator) * [mightp-librenms](https://github.com/magnuslarsen/librenms-puppet) * [landcareresearch-ckan](https://bitbucket.org/landcareresearch/puppet-ckan) * [pltraining-classroom_legacy](https://github.com/puppetlabs/pltraining-classroom_legacy) * [myDistro-configuration](https://github.com/myDistro/configuration) * [pennycoders-phalconphp](https://github.com/pennycoders/puppet-phalconphp) * [sbadia-gitlab](https://github.com/sbadia/puppet-gitlab.git) * [factorit-icingaweb2](https://github.com/Icinga/puppet-icingaweb2.git) * [maany-simple_grid](https://github.com/WLCG-Lightweight-Sites/simple_grid_puppet_module) * [puppet-misp](https://github.com/voxpupuli/puppet-misp) * [puppet-r10k](https://github.com/voxpupuli/puppet-r10k) * [ULHPC-slurm](https://github.com/ULHPC/puppet-slurm)
Breaking changes to this file MAY impact these 65 modules (near match): * [214310-mediawiki](https://forge.puppet.com/214310/mediawiki) * [vinaycharles-mediawiki](https://forge.puppet.com/vinaycharles/mediawiki) * [goeldi-letsencrypt](https://forge.puppet.com/goeldi) * [pcfens-yas3fs](https://github.com/pcfens/puppet-yas3fs) * [preethi-mediawiki](https://forge.puppet.com) * [abhaysoni-mediawiki](https://forge.puppet.com/abhaysoni/mediawiki) * [narenv-mediawiki](https://forge.puppet.com/narenv/mediawiki) * [opuscodium-vcsdeploy](https://github.com/opus-codium/puppet-vcsdeploy) * [puppetfinland-librenms](https://github.com/Puppet-Finland/puppet-librenms.git) * [grahamgilbert-crypt](https://github.com/grahamgilbert/puppet-crypt) * [jaysingh-mediawiki](https://forge.puppet.com/jaysingh/mediawiki) * [m3del-sickbeard](https://forge.puppet.com/m3del/sickbeard) * [soli-wrappers](https://github.com/solution-libre/puppet-wrappers) * [eupathdb-apicommonsystem](https://github.com/EuPathDB/puppet-apicommonsystem) * [tsystemsmms-secc_nrpe_checks](https://github.com/T-Systems-MMS/puppet-secc_nrpe_checks) * [suvarnagodri-mediawiki](https://forge.puppet.com/suvarnagodri/mediawiki) * [hemantgangwar-mediawiki](https://forge.puppet.com/hemantgangwar/mediawiki) * [camptocamp-catalog_diff](https://github.com/camptocamp/puppet-catalog-diff) * [evenup-hubot](https://github.com/evenup/evenup-hubot) * [funaccount-mediawiki](http://fun.com/mediawiki) * [nitish741-mediawiki](https://www.google.com) * [opuscodium-dehydrated](https://github.com/opus-codium/puppet-dehydrated) * [niksv-mediawiki](https://forge.puppet.com/niksv/mediawiki) * [puppetfinland-trac_ldap_sync](https://github.com/Puppet-Finland/puppet-trac_ldap_sync.git) * [express42-puppet_reddit](https://github.com/express42/express42-puppet_reddit) * [prakash007-mediawiki](https://forge.puppet.com/prakash007/mediawiki) * [kiranhosamani-mediawiki](https://forge.puppet.com/kiranhosamani/mediawiki) * [pia-mediawiki](https://forge.puppet.com/pia/mediawiki) * [jethrocarr-howalarming](https://github.com/jethrocarr/puppet-howalarming) * [pltraining-wetty](https://github.com/puppetlabs/wetty) * [webserve-mediawiki](https://forge.puppet.com/webserve/mediawiki) * [anthomas-mediawiki](http://www.google.com) * [pbhutani-mediawiki](https://forge.puppet.com/pbhutani/mediawiki) * [compass-learninglocker](https://github.com/ubc/puppet-learninglocker) * [raviforge-mediawiki](https://forge.puppet.com/raviforge/mediawiki) * [Lavaburn-razor](https://github.com/Lavaburn/puppet-razor) * [fheinle-ddns](https://github.com/fheinle/ddnsv6) * [hegdec-mediawiki](https://forge.puppet.com/hegdec/mediawiki) * [mithilas-mediawiki](http://forge.puppet.com) * [camptocamp-kibana](https://github.com/camptocamp/puppet-kibana) * [parthitraining-mediawiki](https://github.com) * [dbsrinivasulu-mediawiki](https://forge.puppet.com/dbsrinivasulu/mediawiki) * [puppet-jenkins_job_builder](https://github.com/voxpupuli/puppet-jenkins_job_builder.git) * [hggh-sshkeymanager](https://github.com/hggh/sshkeymanager-puppet.git) * [example42-tp](https://github.com/example42/puppet-tp) * [PierrickL-scrm](https://github.com/PierrickI3/pierrickl-suitecrm) * [byjupv-mediakwiki](https://forge.puppet.com/byjupv/mediakwiki) * [echoes-wrappers](https://github.com/echoes-tech/puppet-wrappers) * [puppetlabs-git](https://github.com/puppetlabs/puppetlabs-git) * [camptocamp-varnish](https://github.com/camptocamp/puppet-varnish) * [shantanumalik-mediawiki](https://forge.puppet.com/shantanumalik/mediawiki) * [manish1984-mediawiki](https://forge.puppet.com/manish1984/mediawiki) * [saw-multiinstall](https://github.com/ScottWales/puppet-multiinstall) * [gururaj-mediawiki](https://forge.puppet.com/gururaj/mediawiki) * [sunilh-mediawiki](https://forge.puppet.com/sunilh/mediawiki) * [ravishankar1jan-mediawiki](https://forge.puppet.com/ravishankar1jan/mediawiki) * [esakazmi-mediawiki](https://forge.puppet.com/esakazmi/mediawiki) * [stackforge-keystone](https://github.com/openstack/puppet-keystone.git) * [gsachar1-mediawiki](https://forge.puppet.com/gsachar1/mediawiki) * [tedivm-hieratic](https://github.com/tedivm/puppet-hieratic) * [frozenfoxx-hubot](https://github.com/frozenfoxx/puppet-hubot) * [zivtech-drush_fetcher](https://github.com/tizzo/puppet-drush-fetcher.git) * [qroac-isp3node](https://github.com/qroac/puppet-ispconfig) * [rspiak-racktables](https://github.com/sgnl05/sgnl05-racktables) * [geoffwilliams-psquared](https://github.com/GeoffWilliams/psquared)

This module is declared in 109 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.