search

puppetlabs / puppetlabs-vcsrepo

Support for source control repositories
http://forge.puppetlabs.com/puppetlabs/vcsrepo
GNU General Public License v2.0
223 stars 284 forks source link

Module is broken on Debian Buster #620

Closed Programie closed 1 year ago

Programie commented 1 year ago

Describe the Bug

An agent running on Debian Buster (which is still using Ruby 2.5) fails with the following error while loading the providers:

Error: Could not autoload puppet/provider/vcsrepo/svn: /opt/puppetlabs/puppet/cache/lib/puppet/provider/vcsrepo/svn.rb:175: syntax error, unexpected ']'
      return directory[2..].gsub(File::SEPARATOR, '/') i...
                          ^

Expected Behavior

The vcsrepo provider should be loaded as usual.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Execute the agent on a Debian Buster host
  2. Puppet will fail with the error above

Environment

Additional Context

Related to #609.

kenyon commented 1 year ago

Same as #618. Are you sure you're using the all-in-one puppet-agent package from apt.puppet.com, not the package from Debian? The puppet.com packages bundle ruby, so the system ruby version doesn't matter. Tests show this module working with svn and Puppet 7 on Debian 10.

Programie commented 1 year ago

Right, it works fine with the package from apt.puppet.com.