bugfood
commented
8 months ago There are a couple things I couldn't do quite as well as I would like.
-
I don't know the best way to document the possible values of a property. I don't think that
newvalueaccepts adescattribute, but I could be wrong. I asked about this in the puppet community slack: https://puppetcommunity.slack.com/archives/C0W298S9G/p1703790588151839 -
This new feature has an interaction with the
revisionproperty. If bothrevisionandrepository_statusare applied, then the exact behavior depends on the order in which the properties are applied:- If
revisionhappens first, then the repo is cleaned according to the.gitignoreof the target revision. - If
repository_statushappens first, then the repo is cleaned according to the.gitignoreof the original revision. In either case,revisiondoes agit checkout --forceby default, so some local changes may be clobbered anyway. Experimentally,revisionis currently applied first, due to being listed first in the file, but I don't think there's any guarantee of this behavior. I asked about this in the puppet community slack: https://puppetcommunity.slack.com/archives/C0W298S9G/p1703791951239809
- If
I don't think either of these issues should gate merging the PR, but I'm definitely willing to try any suggestions.
Thank you, Corey
Summary
Add support to vcsrepo's git provider to enforce the status of the git repo. The supported statuses are "default_clean" (to clean the repo, while ignoring files in
.gitignoreand "ignore" (to do nothing).Additional Context
This change is written to support other cleaning methods in the future, if desired.
The first commits fix up the existing documentation and unit tests a bit, then the last commit adds the new feature.
Checklist
puppet apply)