puppetlabs / puppetlabs-vcsrepo

Support for source control repositories
http://forge.puppetlabs.com/puppetlabs/vcsrepo
GNU General Public License v2.0
223 stars 284 forks source link

Enhancement/gh 624 syntax error #634

Closed hesco closed 5 months ago

hesco commented 5 months ago

Summary

Catch a certain syntax error, recommend an upgrade to client side puppet version => ^7 New documentation in README.md, CHANGELOG.md, and syntax error exception caught in lib/puppet/provider/vcsrepo/cvs.rb Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

Using puppet6 on the client machine, elicits the syntax error documented at: https://github.com/puppetlabs/puppetlabs-vcsrepo/issues/624

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

smortex commented 5 months ago

601 dropped support for Puppet 6, and was followed with a major version bump with appropriate ChangeLog entry:

https://github.com/puppetlabs/puppetlabs-vcsrepo/blob/f1d9f4d7c0cee7f3ee030a578304a1f7cfaca3aa/CHANGELOG.md?plain=1#L25-L30

We also include metadata that indicate what version of Puppet a module version require:

https://github.com/puppetlabs/puppetlabs-vcsrepo/blob/f1d9f4d7c0cee7f3ee030a578304a1f7cfaca3aa/metadata.json#L76-L81

For these reasons, I am not in favor of adding extra code to give hints for such known bad configurations.

hesco commented 5 months ago

I had rather hoped that r10k puppetfile install would have made a lot of noise about installing a version unsupported this fundamentally in its environment.

601 dropped support for Puppet 6, and was followed with a major version bump with appropriate ChangeLog entry:

https://github.com/puppetlabs/puppetlabs-vcsrepo/blob/f1d9f4d7c0cee7f3ee030a578304a1f7cfaca3aa/CHANGELOG.md?plain=1#L25-L30

We also include metadata that indicate what version of Puppet a module version require:

https://github.com/puppetlabs/puppetlabs-vcsrepo/blob/f1d9f4d7c0cee7f3ee030a578304a1f7cfaca3aa/metadata.json#L76-L81

For these reasons, I am not in favor of adding extra code to give hints for such known bad configurations.

understood. Thank you for your consideration.