search

puppetlabs / puppetlabs-zfs_core

Apache License 2.0
0 stars 37 forks source link

Add relatime property support to zfs #79

Closed h0tw1r3 closed 4 months ago

h0tw1r3 commented 5 months ago

need this myself, cleaned up #76 as author was unresponsive

AriaXLi commented 4 months ago

Hi @h0tw1r3 thanks again for cleaning this up and contributing! Since this attribute is only supported on Linux platforms, it's causing some issues in CI. 

11:26:36   Error: Could not run: Execution of '/usr/sbin/zfs get -H -o value relatime tstpool/tstfs' returned 2: bad property list: invalid property 'relatime'
11:26:39   For more info, run: zfs help get

When you can, could you please update this PR to account for this? We have some other Linux-only properties that handle this in type (for overlay): https://github.com/puppetlabs/puppetlabs-zfs_core/blob/e16b1c2b8487ef4cfc71f4388003b8c623b47cb0/lib/puppet/type/zfs.rb#L83-L89

Or in provider (for aclmode): https://github.com/puppetlabs/puppetlabs-zfs_core/blob/e16b1c2b8487ef4cfc71f4388003b8c623b47cb0/lib/puppet/provider/zfs/zfs.rb#L60-L69

mhashizume commented 3 months ago

Adding the "skip changelog" label to this PR since it was superseded by https://github.com/puppetlabs/puppetlabs-zfs_core/pull/84