search

puppetlabs / puppetserver-helm-chart

The Helm Chart for Puppet Server
Apache License 2.0
51 stars 56 forks source link

7.4.1 changes break conf.d #164

Closed justicel closed 1 year ago

justicel commented 1 year ago

Describe the Bug

Installing the 7.4.1 helm chart results in a broken installation. The conf.d folder is being destroyed by logic introduced in 7.4.1 for non-root.

Expected Behavior

The conf.d folder to not be destroyed.

Steps to Reproduce

The block specifically that needs to be re-worked is here: https://github.com/puppetlabs/puppetserver-helm-chart/blob/284f0eea1fc73cd424e44b7c429ca09e992b73ac/templates/puppetserver-deployment-masters.yaml#L283:L289

It shouldn't be mounting to the conf.d folder as this breaks any existing files in the folder when non-root.

Xtigyro commented 1 year ago

@davidphay Would you mind please checking this one?

davidphay commented 1 year ago

Hi, it should be good now, can you confirm ?

justicel commented 1 year ago

@davidphay Sorry, forgot to respond. It looks to be good now!

Xtigyro commented 1 year ago

Thank you, @davidphay!