search

puppetlabs / puppetserver-helm-chart

The Helm Chart for Puppet Server
Apache License 2.0
47 stars 55 forks source link

Install fails due to missing required variable in values.yaml #186

Closed iscsrwm closed 8 months ago

iscsrwm commented 11 months ago

Describe the Bug

r10k.code.readinessProbe is not defined in the default values.yaml file. This prevents the chart from installing. Either the doco should be updated to note this requirement or a default value should be added to the file.

Expected Behavior

Installation to complete without errors.

Steps to Reproduce

Steps to reproduce the behavior:

  1. helm repo add puppet https://puppetlabs.github.io/puppetserver-helm-chart
  2. help repo update
  3. helm install --namespace puppetserver puppetserver puppet/puppetserver --set puppetserver.puppeturl='https://somerepo.com/control-repo.git'

Environment

Additional Context

Error: INSTALLATION FAILED: Deployment.apps "puppetserver-puppetserver-master" is invalid: spec.template.spec.containers[1].readinessProbe.exec.command: Required value

qdii commented 9 months ago

I think this breaks the default installation of the helm chart for version 8.1.1. Could the PR be merged and a new version of the chart released?

qdii commented 9 months ago

A workaround is to set this in the helm chart:

r10k:
  code:
    readinessProbe:
      - /bin/true