search

puppetlabs / puppetserver-helm-chart

The Helm Chart for Puppet Server
Apache License 2.0
51 stars 56 forks source link

Fix (#186): wrong init value of r10k-code deployment readinessprobe #188

Closed harunanase closed 11 months ago

harunanase commented 1 year ago

This fix #186

Since we defined r10k.code.readinessProbe in _helpers.tpl,

I think we should use this variable instead of .Values.r10k.code.readinessProbe in r10k-code deployment's readinessProbe to avoid an empty string generate (which might caused the r10k-code pods always in unhealthy if user doesn't define .Values.r10k.code.readinessProbe in their values.yaml)

Thanks.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

uberspot commented 12 months ago

Can we merge this please? Master is broken and we're eager to use it. :D

qdii commented 11 months ago

+1 can we merge?