search

puppetlabs / puppetserver-helm-chart

The Helm Chart for Puppet Server
Apache License 2.0
51 stars 56 forks source link

GitHub Actions workflow: add lint, install, unittest. #195

Closed ldaneliukas closed 10 months ago

ldaneliukas commented 10 months ago

The current GHA workflow is somewhat lacking as it does not properly test the changes that are being done, which could result in merges with a chart that can't be installed.

Separated the workflow into two stages, one for pull requests and one for releases via workflow_dispatch. The job that runs on pull requests tests the chart by running lint, installing it to a cluster and running unit tests. This also removes the required inputs from workflow_dispatch as they can be automatically determined from the context, which will help when releasing it from forks (won't need to update the values every time).

Updating all unittest as part of this as they were already failing, the CI will help with keeping them up to date.

Chart version remains the same, since the Chart templates/functionality were not modified in this PR.

Xtigyro commented 10 months ago

@ldaneliukas Oops, I thought you updated it. My bad. Could you please open a new PR with just that?

ldaneliukas commented 10 months ago

@ldaneliukas Oops, I thought you updated it. My bad. Could you please open a new PR with just that?

Yep, will do later today. Dealing with some time-sensitive things atm.