search

puppetlabs / puppetserver-helm-chart

The Helm Chart for Puppet Server
Apache License 2.0
47 stars 55 forks source link

This line is not necessary, and it is causing puppetdb to crash. #203

Closed felipeatsix closed 5 months ago

felipeatsix commented 6 months ago

As discussed on #202 I'm opening this PR with this simple fix.

CLAassistant commented 6 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: felipeatsix
:x: f.santos

f.santos seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Xtigyro commented 6 months ago

@felipeatsix Thanks for your contribution!

You'd need to sign the CLA. Could you please do so?

Xtigyro commented 5 months ago

@felipeatsix Could you please sign the CLA?

felipeatsix commented 5 months ago

Hi @Xtigyro sorry for the delay, I just noticed that my first commit was submitted using my company username, which it does not have a github account, now I have submitted another commit with my correct username and we can see the CLA assistant is complaining about only 1 out of 2 committers have signed it.

What is the recommended solution in this case?

Xtigyro commented 5 months ago

@felipeatsix The CLA is still not signed. It should be here: https://cla-assistant.io/puppetlabs/puppetserver-helm-chart?pullRequest=203

Also - could you please update the CHANGELOG and bump the minor (second digit) chart version in Chart.yaml?

felipeatsix commented 5 months ago

@Xtigyro The CLA is signed by my personal github account, which is the only one I can use to sign it, however, the problem here is that I sent the first commit using my company git user, which it does not have a github user account related to it, and I can't sign the CLA for that account because it is unexisting in github.

Hence, I prepared a new PR using only my personal account, where I also provided the required changelog updates.

204