search

puppetlabs / puppetserver-helm-chart

The Helm Chart for Puppet Server
Apache License 2.0
52 stars 56 forks source link

Added 'netrc' credentials to documentation #211

Closed cpiment closed 8 months ago

cpiment commented 8 months ago

I was trying to use a control repo cloned by HTTPS instead of SSH, and detected that in the templates existed a r10k.code.viaHttps.credentials setting that was not referenced in the documentation. This PR tries to fix that.

CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

ldaneliukas commented 8 months ago

Thanks for the fix @cpiment! Could you possibly add info on using existingSecret for viaHttps so it matches viaSsh?

cpiment commented 8 months ago

Thanks for your comments @ldaneliukas. I have made the suggested changes to README.md

Xtigyro commented 8 months ago

@cpiment Could you please also bump the bugfix version of the chart in Chart.yaml and update the CHANGELOG.md?

cpiment commented 8 months ago

Hi @Xtigyro, I made the requested changes. Thanks!

ldaneliukas commented 8 months ago

Great! One last thing, the unit test snapshots include the chart version, could you update them with helm unittest . -u. ?

cpiment commented 8 months ago

Hi @ldaneliukas, I have updated the unit test snapshots as requested. Thanks!