Fix permission issue and template issues

[johannagnarsson]

First two changes will fix the puppetdb-preinit container from failing with a mkdir: cannot create directory ‘/opt/puppetlabs/server/data/puppetdb/certs’: Permission denied when puppetmasters.preGeneratedCertsJob.enabled is set to true. as it tries to run as non-root by default even if it's disabled. Second change fixes a broken reference to the puppetmaster-preinstall configmap which prevents the server from starting up correctly when puppetmasters.preGeneratedCertsJob.enabled is set to true.

[CLAassistant]

All committers have signed the CLA.

[johannagnarsson]

Changes made as requested! @Xtigyro

[johannagnarsson]

Result below, I do see the same fails on the upstream repo as well.

Chart [ puppetserver ] .

FAIL test jmx serviceMonitor creation tests/jmx-servicemonitor_test.yaml

• should fail if monitoring.coreos.com/v1 api is not available

  - asserts[0] `failedTemplate` fail
      Template:   puppetserver/templates/jmx-servicemonitor.yaml
      DocumentIndex:  0
      Expected to equal:
          ERROR: You have to deploy monitoring.coreos.com/v1 first
      Actual:
          You have to deploy monitoring.coreos.com/v1 first

  PASS test puppet puppet volume creation tests/puppetdb-pvc_test.yaml FAIL test puppetdb serviceMonitor creation tests/puppetdb-servicemonitor_test.yaml

• should fail if monitoring.coreos.com/v1 api is not available

  - asserts[0] `failedTemplate` fail
      Template:   puppetserver/templates/puppetdb-servicemonitor.yaml
      DocumentIndex:  0
      Expected to equal:
          ERROR: You have to deploy monitoring.coreos.com/v1 first
      Actual:
          You have to deploy monitoring.coreos.com/v1 first

  PASS test puppetdb networkpolicy creation tests/puppetdb.networkpolicy_test.yaml PASS test puppet ca volume creation tests/puppetserver-ca-pvc_test.yaml FAIL test puppet code volume creation tests/puppetserver-code-pvc_test.yaml

• manifest should match snapshot

  - asserts[0] `matchSnapshot` fail
      Template:   puppetserver/templates/puppetserver-code-pvc.yaml

  FAIL test puppetserver compilers statefulset creation tests/puppetserver-compilers.deployment_test.yaml

• manifest should match snapshot

  - asserts[0] `matchSnapshot` fail
      Template:   puppetserver/templates/hiera-configmap.yaml
      Template:   puppetserver/templates/r10k-code.configmap.yaml
      Template:   puppetserver/templates/r10k-hiera.configmap.yaml
      Template:   puppetserver/templates/update-crl-configmap.yaml

  PASS test puppetserver (compilers) networkpolicy creation tests/puppetserver-compilers.networkpolicy_test.yaml PASS test puppetserver compilers podDisruptionBudget creation tests/puppetserver-compilers.pdb_test.yaml FAIL test puppetserver compilers statefulset creation tests/puppetserver-compilers.statefulset_test.yaml

• manifest should match snapshot

  - asserts[0] `matchSnapshot` fail
      Template:   puppetserver/templates/hiera-configmap.yaml
      Template:   puppetserver/templates/r10k-code.configmap.yaml
      Template:   puppetserver/templates/r10k-hiera.configmap.yaml
      Template:   puppetserver/templates/update-crl-configmap.yaml

  FAIL test puppet data volume creation tests/puppetserver-data-pvc_test.yaml

• manifest should match snapshot

  - asserts[0] `matchSnapshot` fail
      Template:   puppetserver/templates/puppetserver-data-pvc.yaml

  PASS test puppetserver (masters) networkpolicy creation tests/puppetserver-masters.networkpolicy_test.yaml PASS test puppetserver master podDisruptionBudget creation tests/puppetserver-masters.pdb_test.yaml PASS test puppet puppet volume creation tests/puppetserver-pvc_test.yaml

Charts: 1 failed, 0 passed, 1 total Test Suites: 6 failed, 8 passed, 14 total Tests: 6 failed, 65 passed, 71 total Snapshot: 12 passed, 12 total Time: 334.573499ms

Error: plugin "unittest" exited with error

[Xtigyro]

@johannagnarsson That's fine. Thank you once more!