search

puppetlabs / puppetserver

Server automation framework and application
https://tickets.puppetlabs.com/browse/SERVER
Apache License 2.0
292 stars 235 forks source link

puppetserver 7.x's logged message about hiera() deprecation includes a broken URL #2835

Closed timmooney closed 3 months ago

timmooney commented 5 months ago

Describe the Bug

puppetserver 7.16 logs a deprecation warning with a broken URL:

2024-03-11T17:43:29.958-05:00 WARN [qtp1601237113-43] [puppetserver] Puppet The function 'hiera' is deprecated in favor of using 'lookup'. See https://puppet.com/docs/puppet/7.29/deprecated_language.html (file & line not available)

Expected Behavior

It's very handy that the puppetserver produces a log message with a "go here to learn more" URL. The only thing that needs to change is for the URL it logs to be updated for the current location.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Use hiera() instead of lookup() somewhere in your puppet code
  2. restart puppetserver on your puppet server.
  3. Do a 'no-op' puppet agent run
  4. browse the /var/log/puppetlabs/puppsetserver/puppetserver.log
  5. copy the URL and paste it into a browser
  6. puppet.com's custom 404 page comes up

Environment

justinstoller commented 3 months ago

Thanks for reporting this! I've looked a bit into it and found the warning is coming from the Puppet code base itself. I've opened a related ticket here that you can track its progress https://github.com/puppetlabs/puppet/issues/9378