search

puppetlabs / r10k

Smarter Puppet deployment
Other
800 stars 353 forks source link

r10k 3.4.0 deploy environment without -p still fetches origin of all repos #1024

Closed buzzdeee closed 3 years ago

buzzdeee commented 4 years ago

Describe the Bug

With r10k 3.3.3 a r10k deploy environment production -v run took only few seconds, now trying to update to 3.4.0, it takes over a minute.

running r10k deploy environment production --verbose=debug2 I can see that after fetching the environment repository, r10k does a fetch origin --prune on all modules configured in the Puppetfile.

running r10k deploy environment production -v I don't see the usual output where it updates all modules, but it takes about the same time as if it would do so, i.e. if I would additionally add the -p option. When I add the -p option, then I also see the additonal output about each updated module.

Note: I've all modules from git, not from puppet forge, so this is at least true for git based modules, don't know about modules from puppet forge.

Expected Behavior

deploying an environment without -p should not fetch all modules, only updating the environment, which should be quite fast.

Steps to Reproduce

update from 3.3.3 to 3.4.0

Environment

Additional Context

ruby26 --version
ruby 2.6.5p114 (2019-10-01 revision 67812) [x86_64-openbsd]

buzzdeee commented 4 years ago

not that I've seen anything related in the changelog, but tested with 3.4.1, and the problem still seems to be there.

adrienthebo commented 4 years ago

Regression introduced in 14039f1d237fc2399fc846738d993718925e8387.

github-actions[bot] commented 3 years ago

This issue has been marked stale because it has had no activity for 60 days. The Puppet Team is actively prioritizing existing bugs and new features, if this issue is still important to you please comment and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.