search

puppetlabs / r10k

Smarter Puppet deployment
Other
800 stars 353 forks source link

Ignore .git folder for forge modules #1052

Closed mwaggett closed 3 years ago

mwaggett commented 4 years ago

Copied from https://tickets.puppetlabs.com/browse/RK-361

Sometimes module authors forget to remove the .git folder when packaging their modules for Puppet Forge. This seems to confuse r10k when running r10k deploy environment -p

The result is that the module is updated in the environment (deleted, unpacked and added again) even though it's already deployed with the same version. This can also result in a race condition if the puppet master tries to compile a catalog for an agent using the module while r10k is unpacking the tarball. The end result is intermittent failed puppet runs.

Can r10k be made to ignore the git folder for modules added from the forge? I don't see any reason for r10k to do anything with these folders anyway.

Affects Versions: r10k 3.4.0

mwaggett commented 4 years ago

cc @yaunj

github-actions[bot] commented 3 years ago

This issue has been marked stale because it has had no activity for 60 days. The Puppet Team is actively prioritizing existing bugs and new features, if this issue is still important to you please comment and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.