puppetlabs / r10k

Smarter Puppet deployment
Other
800 stars 354 forks source link

Allow override of exclude_spec option with puppetfile install subcommand #1362

Closed mdechiaro closed 11 months ago

mdechiaro commented 1 year ago

Describe the Bug

R10K version 4.0.0 enables exclude_spec: true by default according to the changelog. This forces spec/ to be removed when running r10k puppetfile install subcommand. It appears this override only works for deploy according to configuration docs. This parameter should be allowed to be overridden with the puppetfile install subcommand.

R10K v3.16.0 does not have this issue.

Expected Behavior

Allow override of exclude_spec so spec/ can be included when running r10k puppetfile install.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Override exclude_spec according to configuration docs in r10k.yaml
  2. r10k puppetfile install -v
  3. cd modules/test_module/
  4. Verify that spec/ is showing as deleted in git status. The output will look like:
HEAD detached at 05ee699
Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        deleted:    spec/default_facts.yml
        deleted:    spec/spec_helper.rb

no changes added to commit (use "git add" and/or "git commit -a")

Environment

Additional Context

github-actions[bot] commented 11 months ago

This issue has been marked stale because it has had no activity for 60 days. The Puppet Team is actively prioritizing existing bugs and new features, if this issue is still important to you please comment and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.