puppetlabs / r10k

Smarter Puppet deployment
Other
800 stars 354 forks source link

fetch tags to local, if different to remote #1371

Open tmu-sprd opened 8 months ago

tmu-sprd commented 8 months ago

We have the use case, that r10k is pulling modules from our own Git and some modules are applied via puppet apply based on a tag in the Git repository. Therefore it's needed, that the git tags are also updated in the deployed modules by r10k.

This PR adds updating the tags, when they differ local and remote. This is running currently in our production and is working fine.

CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

github-actions[bot] commented 6 months ago

This PR has been marked stale because it has had no activity for 60 days. If you are still interested in getting this merged, please comment and we'll try to move it forward. Otherwise, it will be closed in 7 days.

tmu-sprd commented 6 months ago

Is there anything, I can do, to bring this forward?

justinstoller commented 4 months ago

Sorry, I missed this.

The change looks good, but let me double check the prune => true behavior won't break any use cases.

github-actions[bot] commented 2 months ago

This PR has been marked stale because it has had no activity for 60 days. If you are still interested in getting this merged, please comment and we'll try to move it forward. Otherwise, it will be closed in 7 days.

tmu-sprd commented 2 months ago

I'm still interested to get this merged. Just commenting, to remove the stale label.

github-actions[bot] commented 3 weeks ago

This PR has been marked stale because it has had no activity for 60 days. If you are still interested in getting this merged, please comment and we'll try to move it forward. Otherwise, it will be closed in 7 days.

tmu-sprd commented 3 weeks ago

Still interested.