puppetlabs / r10k

Smarter Puppet deployment
Other
802 stars 355 forks source link

environment deployments: postrun $modifiedenvs lists all environments rather than only those modified #1373

Closed SeanHood closed 2 months ago

SeanHood commented 4 months ago

Describe the Bug

We have started using r10k for deploying Puppet environments on a cron schedule. So we don't specify which environments we want to be deployed. We hoped to use the postrun directive to call a webhook to update chat when environments were deployed. However when ran like this $modifiedenvs contains a list of all deployed environments, whether updated or not.

This seems similar to the bug described in #1215

Expected Behavior

$modifiedenvs to only contain a list of environments which have changed

Steps to Reproduce

Steps to reproduce the behavior:

  1. Post run script:
    
    #!/bin/bash
    echo "$@" > ./modenvs
  2. Append a postrun config
    postrun: ['./postrun.sh', '$modifiedenvs']
  3. Run r10k deploy environment
  4. ./modenvs will contain all of the environments
    $ cat modenvs
    env1 env2

Environment

github-actions[bot] commented 2 months ago

This issue has been marked stale because it has had no activity for 60 days. The Puppet Team is actively prioritizing existing bugs and new features, if this issue is still important to you please comment and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.