search

puppetlabs / r10k

Smarter Puppet deployment
Other
802 stars 355 forks source link

Removal of obsolete multi_json dependency #1388

Open graaff opened 2 months ago

graaff commented 2 months ago

The gemspec still contains a dependency on multi_json. This dependency was added in f7138d49dde3d3399b221f392f89701cf46e78e5 to support the use of faraday_middleware-multi_json, but the faraday dependencies are long gone and nothing else makes use of multi_json.

github-actions[bot] commented 1 week ago

This issue has been marked stale because it has had no activity for 60 days. The Puppet Team is actively prioritizing existing bugs and new features, if this issue is still important to you please comment and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

nabertrand commented 1 week ago

It looks like multi_json is still in the gemspec and ideally would be removed if no longer needed: https://github.com/puppetlabs/r10k/blob/8dd238fe3d3a4c69386348c73f5b8fca001b72fd/r10k.gemspec#L29